Skip to content

[dotnet-code] Consolidate workflow edge registration #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qmuntal merged 2 commits into from
Jun 25, 2026
Merged

[dotnet-code] Consolidate workflow edge registration #352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff2417c
Consolidate workflow edge registration
github-actions[bot] Jun 19, 2026
d88a1f7
Merge branch 'main' into dotnet-code/workflow-edge-registration-a35e8…
michelle-clayton-work Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions workflow/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (wb *Builder) AddDirectEdge(source ExecutorBinding, target ExecutorBinding,
Index: wb.edgeIdx(),
}
applyEdgeOptions(&edge, opts)
wb.edges[source.ID] = append(wb.edges[source.ID], edge)
wb.addEdgeForSource(source.ID, edge)
wb.conditionlessConnections = append(wb.conditionlessConnections, conn)
return wb
}
Expand Down Expand Up @@ -176,7 +176,7 @@ func (wb *Builder) AddFanOutEdge(source ExecutorBinding, targets []ExecutorBindi
Index: wb.edgeIdx(),
}
applyEdgeOptions(&edge, opts)
wb.edges[source.ID] = append(wb.edges[source.ID], edge)
wb.addEdgeForSource(source.ID, edge)
return wb
}

Expand Down Expand Up @@ -205,7 +205,7 @@ func (wb *Builder) AddFanInBarrierEdge(sources []ExecutorBinding, target Executo
}
applyEdgeOptions(&edge, opts)
for _, id := range sourceIDs {
wb.edges[id] = append(wb.edges[id], edge)
wb.addEdgeForSource(id, edge)
}
return wb
}
Expand Down Expand Up @@ -354,6 +354,10 @@ func (wb *Builder) edgeIdx() int {
return wb.edgeCount
}

func (wb *Builder) addEdgeForSource(sourceID string, edge Edge) {
wb.edges[sourceID] = append(wb.edges[sourceID], edge)
}

// validateTypeCompatibility checks that sent message types of source executors
// are compatible with input types of target executors for every edge. It
// creates temporary executor instances to inspect their protocols. If an
Expand Down
Loading