Skip to content

fix: remove libnma and its dep mobile-broadband-provider-info from components#16866

Draft
binujp wants to merge 1 commit intotomls/base/mainfrom
bphilip/nolibnma
Draft

fix: remove libnma and its dep mobile-broadband-provider-info from components#16866
binujp wants to merge 1 commit intotomls/base/mainfrom
bphilip/nolibnma

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Apr 24, 2026

libnma is a networkmanager gui integration libraru. It is not required for azl4 distro which does not support graphical interfaces. mobile-broadband-provider-info is pulled in only because of a libnma dependency. We can get rid of both.

AB#19154

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

Copilot AI review requested due to automatic review settings April 24, 2026 04:32
@binujp binujp requested a review from christopherco as a code owner April 24, 2026 04:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes GUI-related packaging from the Azure Linux 4 component set by dropping libnma and its dependency chain entry mobile-broadband-provider-info, aligning the distro with a non-graphical footprint.

Changes:

  • Delete the dedicated libnma component definition (previously used to disable GTK4 support).
  • Remove mobile-broadband-provider-info from the main base/comps/components.toml component list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
base/comps/libnma/libnma.comp.toml Deletes the libnma component definition, effectively removing the component from the build set.
base/comps/components.toml Removes mobile-broadband-provider-info from the included components list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -2384,7 +2384,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml"]
[components.mkfontscale]
[components.mksh]
[components.mm-common]
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile-broadband-provider-info is still listed in the distro package manifests (e.g. base/packages/sdk.packages.toml includes both mobile-broadband-provider-info and mobile-broadband-provider-info-devel). Removing the component here will make the SDK manifest unresolved unless those entries (and any other references) are removed/updated as part of this PR.

Suggested change
[components.mm-common]
[components.mm-common]
[components.mobile-broadband-provider-info]

Copilot uses AI. Check for mistakes.
@@ -2384,7 +2384,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml"]
[components.mkfontscale]
[components.mksh]
[components.mm-common]
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libnma is still present in the distro package manifests (e.g. base/packages/base.packages.toml includes libnma and libnma-devel). With the component definition removed, those package manifest entries will no longer be satisfiable unless they are also removed/updated (or the package is provided from another repo).

Suggested change
[components.mm-common]
[components.mm-common]
[components.libnma]

Copilot uses AI. Check for mistakes.
…mponents

libnma is a networkmanager gui integration libraru. It is not required for azl4
distro which does not support graphical interfaces. mobile-broadband-provider-info
is pulled in only because of a libnma dependency. We can get rid of both.
@binujp binujp force-pushed the bphilip/nolibnma branch from 9b8e279 to 4b81cef Compare April 24, 2026 04:55
@binujp binujp marked this pull request as draft April 24, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants