fix: remove libnma and its dep mobile-broadband-provider-info from components#16866
fix: remove libnma and its dep mobile-broadband-provider-info from components#16866binujp wants to merge 1 commit intotomls/base/mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes GUI-related packaging from the Azure Linux 4 component set by dropping libnma and its dependency chain entry mobile-broadband-provider-info, aligning the distro with a non-graphical footprint.
Changes:
- Delete the dedicated
libnmacomponent definition (previously used to disable GTK4 support). - Remove
mobile-broadband-provider-infofrom the mainbase/comps/components.tomlcomponent list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
base/comps/libnma/libnma.comp.toml |
Deletes the libnma component definition, effectively removing the component from the build set. |
base/comps/components.toml |
Removes mobile-broadband-provider-info from the included components list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -2384,7 +2384,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml"] | |||
| [components.mkfontscale] | |||
| [components.mksh] | |||
| [components.mm-common] | |||
There was a problem hiding this comment.
mobile-broadband-provider-info is still listed in the distro package manifests (e.g. base/packages/sdk.packages.toml includes both mobile-broadband-provider-info and mobile-broadband-provider-info-devel). Removing the component here will make the SDK manifest unresolved unless those entries (and any other references) are removed/updated as part of this PR.
| [components.mm-common] | |
| [components.mm-common] | |
| [components.mobile-broadband-provider-info] |
| @@ -2384,7 +2384,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml"] | |||
| [components.mkfontscale] | |||
| [components.mksh] | |||
| [components.mm-common] | |||
There was a problem hiding this comment.
libnma is still present in the distro package manifests (e.g. base/packages/base.packages.toml includes libnma and libnma-devel). With the component definition removed, those package manifest entries will no longer be satisfiable unless they are also removed/updated (or the package is provided from another repo).
| [components.mm-common] | |
| [components.mm-common] | |
| [components.libnma] |
…mponents libnma is a networkmanager gui integration libraru. It is not required for azl4 distro which does not support graphical interfaces. mobile-broadband-provider-info is pulled in only because of a libnma dependency. We can get rid of both.
9b8e279 to
4b81cef
Compare
libnma is a networkmanager gui integration libraru. It is not required for azl4 distro which does not support graphical interfaces. mobile-broadband-provider-info is pulled in only because of a libnma dependency. We can get rid of both.
AB#19154
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology