Skip to content

fix: remove libnma and its dep mobile-broadband-provider-info from components #16866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
binujp wants to merge 1 commit into
base: tomls/base/main
Choose a base branch
from
+0 −12
Draft

fix: remove libnma and its dep mobile-broadband-provider-info from components #16866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion base/comps/components.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2384,7 +2384,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml"]
[components.mkfontscale]
[components.mksh]
[components.mm-common]
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile-broadband-provider-info is still listed in the distro package manifests (e.g. base/packages/sdk.packages.toml includes both mobile-broadband-provider-info and mobile-broadband-provider-info-devel). Removing the component here will make the SDK manifest unresolved unless those entries (and any other references) are removed/updated as part of this PR.

Suggested change
[components.mm-common]
[components.mm-common]
[components.mobile-broadband-provider-info]

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libnma is still present in the distro package manifests (e.g. base/packages/base.packages.toml includes libnma and libnma-devel). With the component definition removed, those package manifest entries will no longer be satisfiable unless they are also removed/updated (or the package is provided from another repo).

Suggested change
[components.mm-common]
[components.mm-common]
[components.libnma]

Copilot uses AI. Check for mistakes.
[components.mobile-broadband-provider-info]
[components.moby-engine]
[components.mock]
[components.mock-core-configs]
Expand Down
7 changes: 0 additions & 7 deletions base/comps/libnma/libnma.comp.toml
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions base/packages/base.packages.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2633,8 +2633,6 @@ packages = [
"libnl3",
"libnl3-cli",
"libnl3-devel",
"libnma",
"libnma-devel",
"libnotify",
"libnozzle1",
"libnsl",
Expand Down
2 changes: 0 additions & 2 deletions base/packages/sdk.packages.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,8 +1735,6 @@ packages = [
"miniz",
"mjpegtools-devel",
"mjpegtools-libs",
"mobile-broadband-provider-info",
"mobile-broadband-provider-info-devel",
"mojo-executor",
"mold",
"mongo-c-driver",
Expand Down
Loading