Skip to content

telemetry: add msgo/ci counter#2314

Merged
gdams merged 1 commit into
microsoft/mainfrom
dev/gadams/ci-tel
May 26, 2026
Merged

telemetry: add msgo/ci counter#2314
gdams merged 1 commit into
microsoft/mainfrom
dev/gadams/ci-tel

Conversation

@gdams
Copy link
Copy Markdown
Member

@gdams gdams commented May 26, 2026

Also adds documentation to users can see what telemetry is being tracked.

@gdams gdams requested a review from a team as a code owner May 26, 2026 07:59
Copilot AI review requested due to automatic review settings May 26, 2026 07:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends Microsoft telemetry in the Go toolchain by adding a CI-provider counter (msgo/ci:*) and introducing end-user documentation describing which telemetry counters are uploaded and how to opt out.

Changes:

  • Add CI environment detection in cmd/go telemetry stats and increment a new msgo/ci:<provider> counter.
  • Update vendored github.com/microsoft/go-infra/telemetry to include DetectCI plus upload-config changes (including the new CI counter).
  • Add and link new documentation (eng/doc/Telemetry.md) describing uploaded counters and opt-out behavior.

Patches are happy!

Show a summary per file
File Description
patches/0009-Add-appinsights-telemetry.patch Adds msgo/ci:* incrementing logic and related telemetry stat updates.
patches/0001-Vendor-external-dependencies.patch Vendors updated telemetry library/config, including DetectCI and new counter definitions.
eng/doc/Telemetry.md New user-facing documentation of Microsoft telemetry counters and opt-out instructions.
eng/doc/README.md Links the new telemetry documentation from the doc index.
eng/doc/MigrationGuide.md Points users to Telemetry.md for what’s collected and opt-out steps.
eng/doc/AdditionalFeatures.md Adds Telemetry.md link alongside the existing data-collection policy reference.

Copilot's findings

  • Files reviewed: 6/6 changed files
  • Comments generated: 3

Comment thread patches/0009-Add-appinsights-telemetry.patch
Comment thread patches/0001-Vendor-external-dependencies.patch
Comment thread eng/doc/Telemetry.md
@gdams gdams force-pushed the dev/gadams/ci-tel branch from c13e021 to 6a4b2df Compare May 26, 2026 08:17
@gdams gdams enabled auto-merge (squash) May 26, 2026 08:17
@gdams gdams merged commit eb04310 into microsoft/main May 26, 2026
79 checks passed
@gdams gdams deleted the dev/gadams/ci-tel branch May 26, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants