Update nn.Sequential signature to match PyTorch (*modules varargs)#2827
Merged
justinchuby merged 3 commits intomainfrom Feb 26, 2026
Merged
Update nn.Sequential signature to match PyTorch (*modules varargs)#2827justinchuby merged 3 commits intomainfrom
nn.Sequential signature to match PyTorch (*modules varargs)#2827justinchuby merged 3 commits intomainfrom
Conversation
…PyTorch Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update nn.Sequential signature to match PyTorch
Update Feb 25, 2026
nn.Sequential signature to match PyTorch (*modules varargs)
justinchuby
reviewed
Feb 25, 2026
justinchuby
approved these changes
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 239 239
Lines 28989 28991 +2
Branches 2859 2859
=======================================
+ Hits 20809 20811 +2
Misses 7209 7209
Partials 971 971 ☔ View full report in Codecov by Sentry. |
Collaborator
gramalingam
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nn.Sequential.__init__accepted alist[Module] | Noneparameter, diverging from PyTorch'storch.nn.Sequentialwhich takes variadic positional args.Changes
nn/_sequential.py: Added__init__(self, *modules: Module)override that accepts variadic args and delegates toModuleList.__init__; updated docstring example.nn/_module_test.py: Migrated allSequential([...])call sites toSequential(...).Before / After
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.