Skip to content

Update nn.Sequential signature to match PyTorch (*modules varargs) #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinchuby merged 3 commits into from
Feb 26, 2026
Merged

Update nn.Sequential signature to match PyTorch (*modules varargs) #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4a25ac
Initial plan
Copilot Feb 25, 2026
161441e
Update nn.Sequential signature to accept *modules (varargs) matching …
Copilot Feb 25, 2026
5b6d35c
Apply suggestion from @justinchuby
justinchuby Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions onnxscript/nn/_module_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,7 @@ def forward(self, op, x):
return op.Add(x, op.Constant(value_float=1.0))

graph, op, x = self._make_input()
seq = Sequential([AddOne(), AddOne(), AddOne()])
seq = Sequential(AddOne(), AddOne(), AddOne())
result = seq(op, x)

self.assertIsInstance(result, ir.Value)
Expand All @@ -869,7 +869,7 @@ def forward(self, op, x):
return op.Identity(x)

_, op, x = self._make_input()
seq = Sequential([PassThrough()])
seq = Sequential(PassThrough())
result = seq(op, x)
self.assertIsInstance(result, ir.Value)

Expand Down Expand Up @@ -899,7 +899,7 @@ def forward(self, op, pair):
return op.Add(a, b)

graph, op, x = self._make_input()
seq = Sequential([SplitTwo(), UnpackAndAdd()])
seq = Sequential(SplitTwo(), UnpackAndAdd())
result = seq(op, x)

self.assertIsInstance(result, ir.Value)
Expand All @@ -920,7 +920,7 @@ def forward(self, op, pair):
return op.Add(a, b)

_, op, x = self._make_input()
seq = Sequential([SplitTwoList(), UnpackAndAdd()])
seq = Sequential(SplitTwoList(), UnpackAndAdd())
result = seq(op, x)
self.assertIsInstance(result, ir.Value)

Expand All @@ -938,7 +938,7 @@ def forward(self, op, pair):
return pair

_, op, x = self._make_input()
seq = Sequential([ReturnPair(), TupleIdentity()])
seq = Sequential(ReturnPair(), TupleIdentity())
result = seq(op, x)
self.assertIsInstance(result, tuple)
self.assertEqual(len(result), 2)
Expand All @@ -951,7 +951,7 @@ def forward(self, op, x):
return (op.Identity(x), op.Identity(x))

_, op, x = self._make_input()
seq = Sequential([ReturnPair()])
seq = Sequential(ReturnPair())
result = seq(op, x)
self.assertIsInstance(result, tuple)
self.assertEqual(len(result), 2)
Expand All @@ -968,7 +968,7 @@ def forward(self, op, x):
return (op.Identity(x), op.Identity(x), op.Identity(x))

_, op, x = self._make_input()
seq = Sequential([Identity(), SplitThree()])
seq = Sequential(Identity(), SplitThree())
result = seq(op, x)
self.assertIsInstance(result, tuple)
self.assertEqual(len(result), 3)
Expand All @@ -987,7 +987,7 @@ def forward(self, op, x):

_, op = _create_graph_and_op()
accept = AcceptNone()
seq = Sequential([ReturnNone(), accept])
seq = Sequential(ReturnNone(), accept)
result = seq(op, "anything")
self.assertIsNone(result)
self.assertIsNone(accept.received)
Expand All @@ -1008,7 +1008,7 @@ def forward(self, op, x):
class Model(Module):
def __init__(self):
super().__init__("model")
self.layers = Sequential([Linear(4, 4), Linear(4, 4)])
self.layers = Sequential(Linear(4, 4), Linear(4, 4))

def forward(self, op, x):
return self.layers(op, x)
Expand All @@ -1035,7 +1035,7 @@ def __init__(self, size):
def forward(self, op, x):
return op.MatMul(x, op.Transpose(self.weight, perm=[1, 0]))

seq = Sequential([SiLU(), Linear(4)])
seq = Sequential(SiLU(), Linear(4))
named = dict(seq.named_parameters())
# SiLU at index 0 has no params; Linear at index 1 has weight
self.assertIn("1.weight", named)
Expand All @@ -1061,7 +1061,7 @@ def forward(self, op, x):
class Model(Module):
def __init__(self):
super().__init__("model")
self.blocks = Sequential([])
self.blocks = Sequential()
# Append AFTER __setattr__ has set Sequential._name = "blocks"
self.blocks.append(Linear(4))
self.blocks.append(Linear(4))
Expand Down
5 changes: 4 additions & 1 deletion onnxscript/nn/_sequential.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@ def forward(self, op, x):

# Produces parameter names: "mod.0.weight", "mod.0.bias"
# SiLU at index 0 has no parameters.
mod = Sequential([SiLU(), Linear(4, 4)])
mod = Sequential(SiLU(), Linear(4, 4))

# Calling mod(op, x) is equivalent to:
# x = silu(op, x)
# x = linear(op, x)
"""

def __init__(self, *modules: _module_list.Module) -> None:
super().__init__(modules)

def _set_name(self, name: str) -> None:
"""Set this container's name. Children keep simple ``"0"``, ``"1"`` names.

Expand Down
Loading