fix(cobuilds): add socket + connect timeout#5797
Open
aramissennyeydd wants to merge 4 commits intomicrosoft:mainfrom
Open
fix(cobuilds): add socket + connect timeout#5797aramissennyeydd wants to merge 4 commits intomicrosoft:mainfrom
aramissennyeydd wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <aramissennyeydd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With #5325, we're seeing more recoveries of redis issues but also more hanging agents that are waiting for the redis reconnect to happen. Adding in a socket timeout to prevent that hanging behavior.
Details
We'd have logs like
when there were network issues. The build time is 38 minutes longer than it usually takes. As you can see in the above, we sometimes reconnect but generally, the build agent hangs indefinitely.
How it was tested
Impacted documentation
n/a