Skip to content

fix(cobuilds): add socket + connect timeout #5797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aramissennyeydd wants to merge 4 commits into
base: main
Choose a base branch
from
+15 −1
Open

fix(cobuilds): add socket + connect timeout #5797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8100337
fix(cobuilds): add socket + connect timeout
aramissennyeydd May 7, 2026
ebd1496
scope to just timeout additions
aramissennyeydd May 7, 2026
48e41d5
rename changefile package
aramissennyeydd May 7, 2026
f665bf9
rename changefile package
aramissennyeydd May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/fix-redis-reconnect_2026-05-07-00-00.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Set Redis `connectTimeout` and `socketTimeout` so half-dead TCP connections (NAT/firewall) surface in seconds instead of stalling in-flight commands for many minutes while the kernel waits to give up.",
"type": "patch"
}
],
"packageName": "@microsoft/rush"
}
6 changes: 5 additions & 1 deletion rush-plugins/rush-redis-cobuild-plugin/src/RedisCobuildLockProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ export class RedisCobuildLockProvider implements ICobuildLockProvider {

public constructor(options: IRedisCobuildLockProviderOptions, rushSession: RushSession) {
this._options = RedisCobuildLockProvider.expandOptionsWithEnvironmentVariables(options);
// Provide a default reconnect strategy that prevents more than 5 reconnect attempts.
// Detect half-dead connections quickly. Without `socketTimeout`, a silently-dropped
// TCP connection (NAT/firewall) can stall in-flight commands for many minutes while
// the kernel waits to surface the failure.
this._options.socket = {
connectTimeout: 10_000,
socketTimeout: 30_000,
reconnectStrategy: (count: number) => {
this._terminal.writeErrorLine(`Redis client reconnecting attempt #${count}`);
return count < 5 ? count * 1000 : false;
Expand Down
Loading