Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 1218: Build ID 2976570#8293

Open
dotnet-bot wants to merge 1 commit into
mainfrom
locfiles/2e8d2726-9b4a-4723-9a73-b497512a0d4d
Open

Localized file check-in by OneLocBuild Task: Build definition ID 1218: Build ID 2976570#8293
dotnet-bot wants to merge 1 commit into
mainfrom
locfiles/2e8d2726-9b4a-4723-9a73-b497512a0d4d

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

Copilot AI review requested due to automatic review settings May 16, 2026 14:36
@github-actions github-actions Bot enabled auto-merge (squash) May 16, 2026 14:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR checks in OneLocBuild-generated localized XLF updates for MSTest framework assertion summary messages.

Changes:

  • Localizes IsFalseFailedSummary and IsTrueFailedSummary across supported locales.
  • Localizes IsNullFailedSummary and IsNotNullFailedSummary for a subset of locales.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.cs.xlf Adds Czech translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.de.xlf Adds German translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.es.xlf Adds Spanish translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.fr.xlf Adds French translations for boolean assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.it.xlf Adds Italian translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ja.xlf Adds Japanese translations for boolean assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ko.xlf Adds Korean translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.pl.xlf Adds Polish translations for boolean assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.pt-BR.xlf Adds Brazilian Portuguese translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.ru.xlf Adds Russian translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.tr.xlf Adds Turkish translations for boolean assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hans.xlf Adds Simplified Chinese translations for assertion summaries.
src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.zh-Hant.xlf Adds Traditional Chinese translations for assertion summaries.

<trans-unit id="IsNullFailedSummary">
<source>Expected value to be null.</source>
<target state="new">Expected value to be null.</target>
<target state="translated">預期值可為 Null。</target>
Copy link
Copy Markdown
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization PR — Automated OneLocBuild check-in

All 13 changed files are .xlf localization files updated by the automated OneLocBuild pipeline (dotnet-bot). This is the expected workflow — no manual edits.

Translations reviewed: IsFalseFailedSummary, IsTrueFailedSummary, IsNullFailedSummary, IsNotNullFailedSummary across cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant.

One finding: The zh-Hant translation for IsNullFailedSummary uses 可為 ("can be") rather than the intended "should be" / "must be" semantics — see inline comment. Worth flagging to the localization team.

Minor observation: zh-Hant capitalizes False/True/Null while zh-Hans uses lowercase false/true/null. This is a stylistic inconsistency between the two Chinese variants, though it may reflect intentional localization choices for each variant.

Generated by Expert Code Review (on open) for issue #8293 · ● 7M

<target state="new">Expected value to be null.</target>
<target state="translated">預期值可為 Null。</target>
<note />
</trans-unit>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential semantic inaccuracy (zh-Hant IsNullFailedSummary)

Source: "Expected value to be null."
Translation: "預期值可為 Null." — back-translates as "Expected value can be null" (可為 = can be).

The intended meaning is that the value must/should be null (assertion failure context), so 應為 or 必須為 would be more accurate than 可為. This may cause confusion for Traditional Chinese users reading assertion failure messages.

Recommend flagging to the localization team for correction in the next cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants