Fix weird formatting on augment decorator args#10556
Conversation
…rator args When the total line is too long, decorators now break to separate lines. Augment decorator args are consistently indented when line breaks. Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/240ff9c4-ccdb-4cca-a7fa-ca50fd11aa73 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
commit: |
|
@copilot test and formatting are failing, please fix |
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/eff531f1-d7bc-4d22-a6a3-15a74326da23 Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Fixed in f369aee. The issues were:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
@copilot I am not sure I want to force this decorator break, is it necessary
There was a problem hiding this comment.
You're right, it's not necessary for the core fix. Reverted the operation decorator forced break in 1c33914. The PR now only fixes the augment decorator args asymmetric indentation (first arg hugging the paren while others were indented).
…or fix only Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/16c58b53-c013-400b-82de-48e778ff121d Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot add changelog for @typespec/http-client-java |
Agent-Logs-Url: https://github.com/microsoft/typespec/sessions/6c0baa8c-3a2f-46fe-bc50-c04aa7c3b89e Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
|
You can try these changes here
|
Augment decorator args broke asymmetrically (first arg hugging
(, rest indented).Changes
printAugmentDecoratorArgs: Addsoftlinebefore the first argument (targetType), matchingprintCallLikeArgsbehavior for consistent indentation on break.Before/After