Skip to content

Fix weird formatting on augment decorator args #10556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+34 −4
Open

Fix weird formatting on augment decorator args #10556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ead4ca
Initial plan
Copilot Apr 29, 2026
57c7cb0
fix: improve formatter handling of decorators on ops and augment deco…
Copilot Apr 29, 2026
f369aee
fix: reformat files affected by formatter changes and update snapshots
Copilot May 1, 2026
1c33914
revert: remove operation decorator forced break, keep augment decorat…
Copilot May 4, 2026
10d511d
chore: add changelog entry for @typespec/http-client-java
Copilot May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-formatter-decorator-op-augment-2026-04-29.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/compiler"
---

Fix formatting of decorators on operations and augment decorators. Decorators on operations now break to separate lines when the total line exceeds the print width. Augment decorator arguments are now consistently indented when the line breaks, matching TypeScript/prettier function call formatting.
7 changes: 7 additions & 0 deletions .chronus/changes/fix-formatter-decorator-op-augment-java-2026-04-29.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: internal
packages:
- "@typespec/http-client-java"
---

Reformat augment decorator arguments in test files to match updated formatter style.
2 changes: 1 addition & 1 deletion packages/compiler/src/formatter/print/printer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ function printAugmentDecoratorArgs(
group([
indent(
join(", ", [
path.call(print, "targetType"),
[softline, path.call(print, "targetType")],
...path.map((arg) => [softline, print(arg)], "arguments"),
]),
),
Expand Down
16 changes: 15 additions & 1 deletion packages/compiler/test/formatter/formatter.test.ts
View file
Open in desktop
Copy link
Copy Markdown
Member

@timotheeguerin timotheeguerin May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I am not sure I want to force this decorator break, is it necessary

Copy link
Copy Markdown
Contributor Author

Copilot AI May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it's not necessary for the core fix. Reverted the operation decorator forced break in 1c33914. The PR now only fixes the augment decorator args asymmetric indentation (first arg hugging the paren while others were indented).

Original file line number Diff line number Diff line change
Expand Up @@ -2483,10 +2483,24 @@ namespace Foo {
@@doc(Foo, "This is getting very very very long 1", "This is getting very very very long 2", "This is getting very very very long 3");
`,
expected: `
@@doc(Foo,
@@doc(
Foo,
"This is getting very very very long 1",
"This is getting very very very long 2",
"This is getting very very very long 3"
);
`,
});
});

it("break arguments per lines when decorator name is very long", async () => {
await assertFormat({
code: `
@@Some.Very.Long.Namespace.Decorator.Some.Very.Long.Namespace.Decorator.Some.Very.Long.Namespace.Decorator(subscribe1);
`,
expected: `
@@Some.Very.Long.Namespace.Decorator.Some.Very.Long.Namespace.Decorator.Some.Very.Long.Namespace.Decorator(
subscribe1
);
`,
});
Expand Down
6 changes: 4 additions & 2 deletions packages/http-client-java/generator/http-client-generator-test/tsp/external.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,16 @@ interface ExternalOp {
postExternal(@body body: Body): Body;
}

@@alternateType(CloudEventDataFormat,
@@alternateType(
CloudEventDataFormat,
{
identity: "com.azure.core.models.CloudEventDataFormat",
},
"java"
);

@@alternateType(DayOfWeek,
@@alternateType(
DayOfWeek,
{
identity: "java.time.DayOfWeek",
},
Expand Down
Loading