Add debug logs when writing to persistent storage (#18288) - #26161
Shriraj Jadhav (Shriraj1901) wants to merge 1 commit into
Conversation
Adds traceVerbose logging calls at the two write paths in persistentState.ts: - PersistentState.updateValue() - the core write path used by both global and workspace persistent state - updateWorkspaceStateValue() - a separate direct write path This makes it easier to diagnose issues related to persistent storage writes, as requested in the issue. Verified: eslint and prettier pass cleanly on the changed file, tsc compiles with no errors, and pre-existing test failures in testing/utils.unit.test.js were confirmed unrelated (same failures occur with this change stashed out).
|
🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR. |
|
Result: Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: TypeScript compilation. The relevant tests could not be fully run in the isolated environment; this review is not fully verified. Summary: Offline dependency installation succeeded, and targeted ESLint and Prettier checks passed. TypeScript compilation did not run because the command referenced a nonexistent `typescript/bin/tsc.js`, an invocation issue unrelated to the PR. Consequently, the persistent-state unit suite could not be executed. Existing tests exercise writes but do not assert either newly added verbose log, so the logging behavior needs dedicated coverage. Test runs: 4 passed, 1 failed, 1 not run
❌
|
Bill Schnurr (bschnurr)
left a comment
There was a problem hiding this comment.
Approved via Review Center.
Adds
traceVerboselogging calls at the two write paths inpersistentState.ts:PersistentState.updateValue()— the core write path used by both global and workspace persistent stateupdateWorkspaceStateValue()— a separate direct write pathThis makes it easier to diagnose issues related to persistent storage writes, following the same pattern already used for
traceErrorin this file.How this was verified
eslintandprettier --checkpass cleanly on the changed filetsc --noEmitcompiles with no errorstesting/utils.unit.test.jswere confirmed unrelated to this change (same failures reproduce with this change stashed out, viagit stash)Fixes #18288