Skip to content

Add debug logs when writing to persistent storage (#18288) #26161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shriraj Jadhav (Shriraj1901) wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Add debug logs when writing to persistent storage (#18288) #26161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/client/common/persistentState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { inject, injectable, named, optional } from 'inversify';
import { Memento } from 'vscode';
import { IExtensionSingleActivationService } from '../activation/types';
import { traceError } from '../logging';
import { traceError, traceVerbose } from '../logging';
import { ICommandManager } from './application/types';
import { Commands } from './constants';
import {
Expand Down Expand Up @@ -43,6 +43,7 @@ export async function updateWorkspaceStateValue<T>(key: string, value: T): Promi
throw new Error('Workspace state not initialized');
}
try {
traceVerbose(`Updating workspace persistent state for key [${key}]`);
_workspaceKeys.push(key);
await _workspaceState.update(key, value);
const after = getWorkspaceStateValue(key);
Expand Down Expand Up @@ -85,6 +86,7 @@ export class PersistentState<T> implements IPersistentState<T> {

public async updateValue(newValue: T, retryOnce = true): Promise<void> {
try {
traceVerbose(`Updating persistent state for key [${this.key}]`);
if (this.expiryDurationMs) {
await this.storage.update(this.key, { data: newValue, expiry: Date.now() + this.expiryDurationMs });
} else {
Expand Down