NpmDsc: Avoid Set false positives with owner/repo packages

[guillermooo]

The old implementation didn't account for all possible one/two package names accepted by npm install.

We now limit user input to package names that won't yield false positives in these cases.

NOTES:

The fix is actually restricted to one/two type of names; other legal values for a package name may still yield false positives if they reference a code repository. (Untested)

• I have signed the Contributor License Agreement.
• This pull request is related to an issue.

---

Microsoft Reviewers: Open in CodeFlow

[Gijsreyn]

@guillermooo - thanks for the PR. Can you perhaps include tests in https://github.com/microsoft/winget-dsc/blob/main/tests/NpmDsc/NpmDsc.tests.ps1? The same will be for #250.

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

npmjs

These words are not needed and should be removed

Jan PSobject tokio winget

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:guillermooo/winget-dsc.git repository
on the users/guillermooo/avoid-set-op-false-positives branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/winget-dsc/actions/runs/23022688725/attempts/1'

Warnings (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

⚠️ Warnings	Count
⚠️ no-newline-at-eof	1

See ⚠️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[guillermooo]

@Gijsreyn Tests added.

[Gijsreyn]

@Gijsreyn Tests added.

I think you need to fix up the spelling checker. @AmelBawa-msft - I think I can't run the Azure Pipelines, mind giving it a spin for Guillermo?