Skip to content

gpu-gates: q8_2 quantization silently drops a partial block #175

Closed

Description

@github-actions

The unchanged loop in ik_q8_2::quantize walks only x.as_chunks::<32>().0. Passing 33 finite values returns 32 codes and one scale without an error. gate_deepseek41_step::v_q8_2 then indexes q[c] for every input value; the Q8_0 project functions also ignore the partial block. The whole-block check lives in reconstruct, so direct callers bypass it. Add that named assertion to quantize and pin rejection of a 33-value input.

Evidence (at the base of #174):

Filed by Shingler, the review bot, while reviewing #174; the defect is outside that pull request.

Activity

  1. added
    review-botFiled by the PR review bot: a defect found outside the reviewed pull request
    on Oct 14, 2026
  2. juliankang4 commented on Oct 14, 2026

    @juliankang4
    Collaborator

    I'll take this first once our open pull requests (#164, #172, #173 and #174) are merged. #174 changes crates/gpu-gates/src/ik_q8_2.rs, where quantize lives, so the fix goes on top of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    review-botFiled by the PR review bot: a defect found outside the reviewed pull request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions