Repository navigation
docs: BUILD.md and serving.md name the nemotron seat, and the README's limit line points to serving.md - #288
Conversation
…s limit line points to serving.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Verdict: CLEAN: The documented Nemotron build, serving limits, and prefix behavior match the implementation.
Checked
Duplicates: 0 new functions, types, or constants; the README links the detailed seat description.
Complexity: no functions changed; no crapper candidates.
Silent failure: 0 changed executable sites.
Tests: no tests changed, so mutation checks do not apply. Documentation link target and build feature declarations checked statically.
Behavior: checked CLI dispatch, single-slot and placement guards, draft refusal, prefix reset, and snapshot/resume refusal against the implementation.
Gates: none changed; no pins moved.
Escape catalog: no C1–C4 patterns matched.
Notes
Dryer and crapper did not run because no Rust files changed.
🔨 Shingler, bloomery's review bot: approves a clean pull request and requests changes on a must-fix (how it works)
Follow-up to #278 (its Follow-up item).
docs/BUILD.mdanddocs/serving.mdon main75dc51a6do not name the nemotron seat that v0.3.3 serves.What
docs/BUILD.md, thebloomery-serverow:--modellistsnemotron, and the Models cell names Nemotron 3 Nano 4B. The row's feature set already carries the seat (it sits behinddeepseek41, whichglm5nextenables).docs/serving.md, "The seats": one paragraph on the nemotron seat, held toserve_seats/nemotron.rs's module doc andACTS_ON: one card, one slot;--parallelabove 1, a multi-card or tier-card placement and a draft lever refused by name; one decode step per prompt token; the step-back rule; no prompt cache, a snapshot or resume refused by name.docs/serving.md, "Concurrent requests" said every generative seat takes--parallel N, which the nemotron seat refuses; it now names the exception. The Limits line on one-request seats names it too.--hfrows only, as docs: README and models.md list Nemotron 3 Nano 4B, served by -m until its Hugging Face repo is named #278 left it.공통화한 것 (Commonized)
Evidence
crates/gpu-gates/src/bin/shared/serve_seats/nemotron.rsat75dc51a6: lines 22–33 (one sequence,--parallelabove 1 refused, no prompt batch, the step-back rule, no prompt cache), 36–40 (placement), 96 (ACTS_ON), 204–209 (snapshot and resume refused).crates/gpu-gates/Cargo.toml:117:glm5next = ["deepseek41", …], so BUILD.md'sglm5next,clef,vision,mimo2build carries the seat (the serve gate buildsbloomery-servewith the same set).just contrib-check --tier t0on 41ab6b4e: every step rc 0 butcheck-recipes, whose one red wastools/review/local.py --self-test's "SIGTERM to local.py ends it and the role's process group: ended True, child alive True". Run alone three times on the same tree: rc 0, 0 FAIL each. An earlier run on 55cbc8b8, beside a pre-review, had its one red ingpu-gate.sh --self-test(a 4 s hold bound waited 282 s); alone it gave 105 of 105 ok. This diff touches neither tool: README.md, docs/BUILD.md and docs/serving.md only.Follow-up (not in this PR)
local.py's SIGTERM process-group case andgpu-gate.sh's fresh-hold wait. Both read a timing the load moves; a bound or a wait on the child's exit, not a sleep, is a tool change of its own.ToolFormat(crates/serve/src/dsml.rs:294) the Nemotron file's template resolves to is not checked here; a serve request with a tool would settle it.Pre-review CLEAN at 41ab6b4ee8635be5cb6d30c6df103d0b4244067a; 2389edf is the same patch on main d213b59 (patch-id 36f92ec4).
🤖 Generated with Claude Code