Skip to content

fix(sock): gate the Linux-only shard test helper - #5769

Merged
kixelated merged 1 commit into
mainfrom
fix/sock-shard-platform
Oct 16, 2026
Merged

fix(sock): gate the Linux-only shard test helper#5769
kixelated merged 1 commit into
mainfrom
fix/sock-shard-platform

Conversation

@kixelated

@kixelated kixelated commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes the macOS and Windows Platform builds, which #5688 broke. Only the Linux steering tests in moq-sock's shard module build CIDs, so on other targets the cid test helper and CID_LEN were dead code. build.warnings turns that warning into an error. Both items are now gated on target_os = "linux", like their callers.

Platform was skipped on #5688's PR runs and is not a required merge-queue check, so the failure only showed up in the queue's merge group (run 38965110664) after the PR had merged.

Public API and wire impact

None. The change is test-only.

Tests

  • just check passes on Linux.
  • I could not build macOS or Windows locally. The failed jobs compiled the whole moq-sock lib test, and these two warnings were the only ones, so Platform on this PR is the check that counts.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@kixelated @claude
fix(sock): gate the Linux-only shard test helper
3e9bde6 
Only the Linux steering tests build CIDs, so macOS and Windows saw `cid`
and `CID_LEN` as dead code and denied the warnings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7cac07b1-780c-4e27-b10f-88d573e92623
📥 Commits

Reviewing files that changed from the base of the PR and between 38436f2 and 3e9bde6.

📒 Files selected for processing: 1
  • rs/moq-sock/src/shard.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T21:42:37.350993Z 3e9bde6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 16, 2026
@kixelated kixelated mentioned this pull request Oct 16, 2026
Merged
Merged via the queue into main with commit a185a1f Oct 16, 2026
10 of 12 checks passed
@kixelated
kixelated deleted the fix/sock-shard-platform branch October 16, 2026 22:22
@kixelated kixelated mentioned this pull request Oct 16, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kixelated