Repository navigation
feat(js/net): list a broadcast's tracks over lite-07 TRACKS #6158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1a5620b
quest: claim quest/m1/archive/tracks-js
kixelated d6d8001
feat(js/net): list a broadcast's tracks over lite-07 TRACKS
kixelated e84f747
fix(js/net): refuse listings through a covering prefix route at the o…
kixelated c7eb3f5
fix(js/net): yield while draining a peer's TRACKS events
kixelated e97b166
fix(js/net): close the session on data after TRACKS, and FIN a finish…
kixelated ae16cf5
Merge origin/main into quest/m1/archive/tracks-js
kixelated c4af683
test(net): set the TRACK_INFO compression codec in the TRACKS interop…
kixelated e93d1d4
fix(js/net): drop a listing answer from a source replaced as it arrived
kixelated ce3c85f
Merge origin/main
kixelated 9d87824
style(js/net): sort resume test imports
kixelated 31a04c3
fix(js/net): refuse a peer's listing that names a compressed track
kixelated 696a3d7
Merge origin/main
kixelated 923f834
test(js/net): serve covering-prefix listing tests through dynamicRoute
kixelated aa4102f
fix(js/net): refuse listing a broadcast consumed over moq-transport
kixelated ac2a3fd
Merge origin/main
kixelated 771611b
Merge origin/main into quest/m1/archive/tracks-js
kixelated 9c77781
Merge origin/main into quest/m1/archive/tracks-js
kixelated ac0b415
Merge origin/main into quest/m1/archive/tracks-js
kixelated 092fe28
Merge origin/main into quest/m1/archive/tracks-js
kixelated e6df222
Merge origin/main into quest/m1/archive/tracks-js
kixelated 7bc9869
Merge origin/main into quest/m1/archive/tracks-js
kixelated 6211690
Merge origin/main into quest/m1/archive/tracks-js
kixelated 5d65245
Merge remote-tracking branch 'origin/main' into iterate-6158
kixelated daf62ee
fix(net): authorize a TRACKS listing like a subscribe
kixelated 86558ab
fix(net): never list a retired epochless instance
kixelated af41d8b
fix(js/net): drop a listing whose readers left as its token settled
kixelated f25ec64
Merge origin/main into quest/m1/archive/tracks-js
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this method is called on a broadcast created by the moq-transport subscriber, it returns an immediately
syncedempty listing becauseietf/subscriber.tsconstructsConsumeBroadcastwithout attaching any listing source. Since SUBSCRIBE_TRACKS is not implemented there, applications silently conclude that a nonempty remote broadcast has no tracks. Have the IETF consumer rejecttracks()as unsupported, as lite versions before 07 do, until its listing protocol is implemented.AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid, fixed in aa4102f. A broadcast consumed over moq-transport now refuses each listing with "track listing requires moq-lite-07 or newer", the same answer lite-06 sessions give, instead of syncing an empty set. Regression test:
a consumed broadcast refuses to list its tracks rather than claim it has noneinjs/net/src/ietf/subscriber.test.ts.The Rust moq-transport subscriber has the same gap (it attaches no lister either); that is outside this JS PR and is left for a follow-up.
(Written by Claude Opus 5.5)