Repository navigation
chore(smoke): update the flake and Playwright pin together - #6210
Conversation
|
Quest completed with the coupled updater, initial lock/Playwright refresh, and guarded Dependabot auto-merge. The real freshness check, updater tests, workflow/alert checks, markdown, and shell/recipe checks pass. No public API or wire change and no open API decisions. The PR remains draft while the baseline stale quest links are addressed by #6205 and the existing Smoke workflow validates the changed published-package toolchain. No new follow-up quests are needed. (Written by GPT-6) |
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
f1462b9 to
f0d10fe
Compare
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0d10fe88f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: GPT-6 <noreply@openai.com>
|
The coupled updater is complete. (Written by GPT-6) |
The weekly proposal is opened by moq-bot, not written by a model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary for head 06f2958.
Follow-up: moq-dev/moq#6169 adds a Dependabot nix entry for (Written by Claude Opus 5.5) |
Problem
Smoke's flake was pinned to May while npm Playwright must exactly match its packaged Chromium. Dependabot can discover a newer smoke lock, but its lock-only update cannot safely auto-merge ahead of the matching npm pin.
Approach
Add a weekly/manual workflow that updates both files, validates freshness and real browser startup, and opens or refreshes one draft PR. Refreshed proposals are always returned to draft. A local
just update-toolchaincommand performs the same update, deriving the exact stable version by evaluating the existing shell hook without building its toolchains. Scheduled failures use the existing alert path. The Dependabot auto-merge workflow refuses smoke-flake proposals and directs maintainers to this coupled updater; its pending smoke entry in #6169 is unchanged.Run the updater now: smoke nixpkgs moves from May 27 to October 20, and Playwright moves from 1.59.1 to the matching 1.64.1. The updater's refusal and coupling tests run through
just freshness, already exercised by nightly Smoke. Remove the completed quest and its reference.Impact
Validation
just gh check, markdown, shellcheck, shfmt, and justfile formatting pass. The auto-merge query refuses smoke locks and accepts unrelated updates.just cipasses after rebasing onto the repaired main branch.just check-toolchainpasses with the refreshed smoke shell and a real Chromium launch. The full published-package media matrix was not run locally; Smoke runs manually on a proposed branch and automatically on main.Alternatives
A handwritten pair of bumps leaves the same recurring drift. Updating untrusted Dependabot checkouts with write credentials adds complexity; the scheduled job evaluates the default branch and uses a maintained pinned PR action instead.
Follow-ups
No new quests or API decisions. This does not touch the Pages cleanup owned by #6207.
(Written by GPT-6)