Repository navigation
quest: plan the 2026-10-25 quest-complete follow-ups and the C direction #6850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8f50825
quest: plan follow-ups from the 2026-10-25 quest-complete run
kixelated 96f0cab
quest: move the C follow-ups to c-retire and moq-audio's grant
kixelated a303e81
Merge remote-tracking branch 'origin/main' into quest/plan-complete-f…
kixelated 4718072
quest: address review of the 2026-10-25 follow-ups
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [S] Probe against Cubic passes | ||
|
|
||
| ## Goal | ||
|
|
||
| `tests::probe::competing_cubic` in `rs/moq-quic/src/tests/probe.rs`, run by | ||
| Nightly through `just rs quic-sim`, passes on `main`, fixed at its cause. | ||
|
|
||
| ## Plan | ||
|
|
||
| [moq-dev/moq#6719](https://github.com/moq-dev/moq/pull/6719) found it failing | ||
| the same way on `main` and on its branch: a probe resends a stream after that | ||
| stream was reset. A reset stream's data is never retransmitted, so find which | ||
| path still queues it (probe padding, a loss-recovery retransmit, or a stale | ||
| send queue entry) and stop it there. The other probe tests in the release | ||
| suite pass, so the fix must keep them passing. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [XS] One meaning for Credential | ||
|
|
||
| ## Goal | ||
|
|
||
| `Credential` means only the public `auth::Credential`. The internal type | ||
| for what one dial presents, in `js/net/src/connection/tokens.ts` and moq-tokio's | ||
| `connect/token.rs`, gets its own name, and the `Presented` import alias in | ||
| `tokens.ts` goes away. | ||
|
|
||
| ## Plan | ||
|
|
||
| [moq-dev/moq#6751](https://github.com/moq-dev/moq/pull/6751) renamed the | ||
| public `Auth` to `Credential`, which collides with these internal types. | ||
| Pick a name by role (such as `Presentation`) and use it in both languages. | ||
| Both types are internal, so nothing public changes. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # [XS] graviola's own CPU check | ||
|
|
||
| ## Goal | ||
|
|
||
| Once a graviola release ships a public CPU feature check | ||
| ([ctz/graviola#227](https://github.com/ctz/graviola/issues/227)), moq-relay | ||
| calls it at startup instead of mirroring graviola's mandatory feature list. | ||
| Check the issue and graviola's changelog; until it ships, this quest waits. | ||
| The startup error still names the missing feature, as relay-graviola | ||
| decided, so a check that answers only yes or no does not replace the mirror. | ||
|
|
||
| ## Plan | ||
|
|
||
| [moq-relay on graviola](/quest/m1/pure-crypto/relay-graviola.md) mirrors the | ||
| list because no public check exists. If the check ships before that quest | ||
| lands, that quest uses it and this one is deleted. | ||
|
|
||
| Public API: none. Wire: none. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # [S] Interop loads the local moq-gst plugin | ||
|
|
||
| ## Goal | ||
|
|
||
| The interop `gst` cells find the locally built moq-gst plugin on every run, | ||
| instead of sometimes failing with "moqsrc not exposed" (the check near | ||
| `test/interop/interop.sh:780`), fixed at its cause. | ||
|
|
||
| ## Plan | ||
|
|
||
| Seen in [moq-dev/moq#6745](https://github.com/moq-dev/moq/pull/6745)'s | ||
| `just test interop --all` runs: one of two runs failed to load the plugin, and | ||
| the other passed. Find whether the plugin build, the registry cache | ||
| (`GST_REGISTRY`), or `GST_PLUGIN_PATH` races between cells, and make the | ||
| harness load the plugin deterministically. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # [S] Swapped Rust publisher to JS Opus in interop | ||
|
|
||
| ## Goal | ||
|
|
||
| The `rust-swapped -> js` interop cell stops timing out on its Opus check | ||
| under local load, fixed at its cause. | ||
|
|
||
| ## Plan | ||
|
|
||
| Seen in [moq-dev/moq#6745](https://github.com/moq-dev/moq/pull/6745)'s | ||
| `just test interop --all` runs: one of two runs timed out on this cell, and | ||
| the other passed. Reproduce under a loaded machine and find whether the JS | ||
| subscriber never receives the Opus track, receives it late, or decodes it and | ||
| misses the check. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # [S] Open-GOP MPEG-2 export trims leading B-pictures | ||
|
|
||
| ## Goal | ||
|
|
||
| When a TS export starts or resumes at an MPEG-2 sequence header in an open | ||
| GOP, it drops the leading B-pictures that reference the previous GOP and | ||
| counts them as `trimmed` or `dropped`, as it already does for codecs whose | ||
| frames carry presentation time. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found while landing [moq-dev/moq#6252](https://github.com/moq-dev/moq/pull/6252): | ||
| whole-PES MPEG-2 frames carry their placement time, not their presentation | ||
| time, so the leading-picture check cannot apply. A GOP header with | ||
| `closed_gop` unset marks an open GOP; its leading pictures are the B-pictures | ||
| (picture coding type) whose temporal reference precedes the I-picture's. | ||
| `broken_link` is the encoder's own flag for an edited stream, not the trigger. | ||
| Cover it with an MPEG-2 open-GOP arm in `recovery_test.rs`, graded like the | ||
| H.264 `Open` arm. Low priority: decoders usually skip these B-pictures. | ||
|
|
||
| Public API: none. Wire: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.