Skip to content

fix(ci): exclude scratch trees from TOML formatting - #7114

Merged
kixelated merged 1 commit into
mainfrom
codex/taplo-ignore-scratch
Oct 29, 2026
Merged

kixelated merged 1 commit into
mainfrom
codex/taplo-ignore-scratch

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

TOML formatting scans generated files in the checkout's ignored .tmp/ tree. A CI test writing a relay config there can fail the formatting lane even though every source TOML file is formatted.

Approach

Exclude scratch trees alongside the existing vendor and build exclusions.

Impact

  • Public API and wire: unchanged. CI configuration only.

Validation

An unformatted .tmp/format-repro.toml makes taplo format --check exit 1 before the change. The same command exits 0 afterward with that file unchanged. Full just ci passes, as does the diff check.

Alternatives

Formatting generated test configs or moving scratch outside the checkout would leave source discovery incorrect.

Follow-ups

None. This fixes a blocker found while finishing the existing PR validation.

(Written by GPT-6)

Co-Authored-By: GPT-6 <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 78e20d93-c9f0-4789-816e-5a960649fff0
Commits

Reviewing files that changed from the base of the PR and between b8a8b4e and 4212e63.

Files selected for processing: 1
  • .taplo.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T16:40:28.551783Z 4212e63 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 4212e63

No actionable bugs found. Adding **/.tmp/** to .taplo.toml is a suitably small fix for the repository-wide Taplo check/fix commands in sh/dispatch.sh: it excludes generated scratch TOML without changing source formatting rules or requiring test generators to format their output.

Verification: static review of the diff, full Taplo configuration, scratch-directory ignores, and formatting dispatch. I did not run Taplo, the reproduction, or CI; the PR's reported validation was not independently reproduced.

@kixelated

Copy link
Copy Markdown
Collaborator Author

This exclude also fixes a second failure mode that dropped moq-dev/moq#7055 from the merge queue (run 40725094730). That run failed check toml with ERROR operation failed error=No such file or directory (os error 2).

  • Since 8eedc45e10, sh/rs/test-lints.test.py (run by test gh) writes .tmp/tmpXXXX/Cargo.toml inside the checkout and deletes it on exit. I confirmed this with strace.
  • taplo 0.10 globs **/*.toml, filters out excluded paths, and only then reads each file (format_files in taplo-cli). One failed read aborts the whole run. If the fixture is removed between the glob and the read, the result is ENOENT.
  • In that run, the toml lane ran from 16:29:26.8 to 16:29:28.1, while the js → … → gh lane was finishing test gh (it ended at 16:29:30.8).

With **/.tmp/** excluded, taplo still walks into .tmp, but it drops those paths before reading them, so this race goes away too.

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing summary: no changes made in the merge pass.

  • Head 4212e63d820d3ad2f0e9e9e54cec9a8e54958c1c: 10/10 checks passed, merge state clean.
  • Reviews: Codex reacted with a thumbs up (no findings), and the automated review from the maintainer's account found nothing actionable. No unresolved threads. CodeRabbit was rate-limited, so per CONTRIBUTING.md it doesn't count.
  • quest check --base origin/main passes (no quest files touched).

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 0bdae79 Oct 29, 2026
10 checks passed
@kixelated
kixelated deleted the codex/taplo-ignore-scratch branch October 29, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant