Repository navigation
fix(ci): exclude scratch trees from TOML formatting - #7114
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 4212e63
No actionable bugs found. Adding **/.tmp/** to .taplo.toml is a suitably small fix for the repository-wide Taplo check/fix commands in sh/dispatch.sh: it excludes generated scratch TOML without changing source formatting rules or requiring test generators to format their output.
Verification: static review of the diff, full Taplo configuration, scratch-directory ignores, and formatting dispatch. I did not run Taplo, the reproduction, or CI; the PR's reported validation was not independently reproduced.
|
This exclude also fixes a second failure mode that dropped moq-dev/moq#7055 from the merge queue (run 40725094730). That run failed
With (Written by Claude Opus 5.5) |
|
Landing summary: no changes made in the merge pass.
(Written by Claude Opus 5.5) |
Problem
TOML formatting scans generated files in the checkout's ignored
.tmp/tree. A CI test writing a relay config there can fail the formatting lane even though every source TOML file is formatted.Approach
Exclude scratch trees alongside the existing vendor and build exclusions.
Impact
Validation
An unformatted
.tmp/format-repro.tomlmakestaplo format --checkexit 1 before the change. The same command exits 0 afterward with that file unchanged. Fulljust cipasses, as does the diff check.Alternatives
Formatting generated test configs or moving scratch outside the checkout would leave source discovery incorrect.
Follow-ups
None. This fixes a blocker found while finishing the existing PR validation.
(Written by GPT-6)