Repository navigation
quest: plan test, clock, and publishing follow-ups - #7191
Conversation
From #7161, #7076 and #7166: moq-clock and kio tests that fail outside nextest or in a workspace build, a JS eviction test that never ages its groups, one clock per broadcast, crates.io OIDC raised to m1, and the `publish` Environment question added to the land quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merging: Codex reviewed head 0bee112 with no findings (👍). (Written by Claude Opus 5.5) |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 0bee112
No actionable bugs found in these planning changes. Separate test-isolation and clock-ownership quests are appropriately scoped: the clock plan includes the ambient reads inside Clock itself and explicitly requires reconciling timestamp semantics, rather than merely clamping regressions. The test plans require preserving the original guarantees and demonstrating meaningful failures. Moving trusted-publisher setup alongside the OIDC implementation keeps its prerequisite visible, while the publishing-environment decision remains explicitly with the maintainer.
Verification: static comparison with the referenced clock and stalled-consumer tests, clock/stamping paths, release workflow, and moved quest links, including an independent clock-plan review. I did not reproduce the reported failures, run tests, or inspect/change external registry or repository settings.
Plans follow-ups from moq-dev/moq#7161, moq-dev/moq#7076 and moq-dev/moq#7166.
Quests
quest/m1/clock-test-process.md[XS]:cargo test -p moq-clockfails on main every time.paused_runtimes_own_their_anchorsassumes it is the first test in its process to read the clock, and passes only under nextest, which runs one process per test. Reproduced 2026-10-29.quest/m1/kio-workspace-tests.md[S]: two kio log eviction tests fail only incargo test --workspace. They pass with-p kio, with and without_sim, so another unified dependency feature is the trigger. ci: unify dependency features with a cargo-hakari workspace-hack #6985's workspace-hack excludes kio, so it won't fix this.quest/m1/js-cache-age-test.md[XS]:broadcast.test.ts"a stalled consumer does not pin evicted groups" moves the system time, which the cache never reads, so the test can't fail.quest/m1/broadcast-clock.md[S]: every group a moq-mux broadcast writes is stamped from the broadcast's own clock. Today catalog, MSF and HLS record groups stamp with the ambientTimestamp::now(), so a call from another runtime can move a track's timestamps backwards.crates-trusted-publisher.mdandrelease-rs-oidc.md.CARGO_REGISTRY_TOKENis the last long-lived registry token.quest/m0/ci/land.md: adds an open question. Maymainkeep deploying to thepublishEnvironment while its ruleset lets role 2 (and, after land, moq-bot) bypass review?Decisions
publishEnvironment onmain:🤖 Generated with Claude Code
(Written by Claude Opus 5.5)