Skip to content

fix: paginate and diagnose GitHub release discovery - #62

Merged
kixelated merged 1 commit into
mainfrom
codex/ci-download-investigation
Oct 22, 2026
Merged

kixelated merged 1 commit into
mainfrom
codex/ci-download-investigation

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The C and GStreamer clients only searched the first 100 GitHub releases. libmoq also reported HTTP failures as "no release found", and both clients treated an empty response body as a missing release. Share one release lookup that follows pagination, selects stable published releases, validates the response, and logs HTTP status, request IDs, rate limits, and unmatched page tags. HTTP and malformed-response failures now have distinct diagnostics.

The exact failures in the apt job and the Nix job remain unproven because their API responses were discarded. Fresh authenticated and anonymous queries both returned 100 releases, with moq-gst-v0.4.17 at position 3 and libmoq-v0.6.17 at position 6. This fixes reproducible lookup defects and preserves evidence for future failures; it does not claim pagination caused that run.

Validation:

  • Reproduced the old functions' misleading errors using empty bodies, HTTP failures, and pages without matching tags.
  • Offline regression tests cover matches beyond 100 releases, short pages with next links, exhaustion, stable selection, retained assets, malformed/empty/multiple-document responses, and HTTP/transport errors. Run by just check and CI. Removing pagination makes the regression suite fail.
  • nix develop --command just check, explicit actionlint, and git diff --check pass.
  • Targeted media smoke passed all five cells: Rust publisher to Rust, C, pkg-config, CMake, and GStreamer subscribers. Used latest public apt moq 0.14.7/moq-relay 0.17.7 and current release tarballs. Supplied CMake through nix shell because the existing dev shell omits it.
  • Cargo CI passed end to end, including the regression suite, full media matrix, negative control, and token interop. Other jobs were still running when this evidence was recorded; this branch retains the original Ubuntu mirror configuration.

Independent of moq-dev/smoke#60 and the mirror fix in moq-dev/smoke#61.

(Written by GPT-6)

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c59b43c0-7c70-40b1-996d-56c50dacc8d6
📥 Commits

Reviewing files that changed from the base of the PR and between cd60b77 and 8183573.

📒 Files selected for processing: 6
  • .github/workflows/smoke.yml
  • freshness.sh
  • justfile
  • release.sh
  • smoke.sh
  • tests/release.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated merged commit f9dd72f into main Oct 22, 2026
8 checks passed
@kixelated
kixelated deleted the codex/ci-download-investigation branch October 22, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant