fix(payments-api): stripe webhooks not recording glean#20421
fix(payments-api): stripe webhooks not recording glean#20421StaberindeZA wants to merge 1 commit intomainfrom
Conversation
Because: - The Stripe webhook handler is not recording glean events. This commit: - Removes mock glean provider from payments-api app module. Closes #PAY-3321
There was a problem hiding this comment.
Pull request overview
Fixes missing Stripe webhook Glean recording by ensuring the payments-api app uses the real Glean provider instead of a mock.
Changes:
- Removes the mock
MockPaymentsGleanFactoryfrom the NestJSAppModuleproviders so real Glean events can be recorded. - Adjusts Nx target configuration for
payments-api(notablyserve/startdependency behavior).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/payments/api/src/app/app.module.ts | Removes the mock Glean DI provider so Stripe webhook code can emit real Glean metrics. |
| apps/payments/api/project.json | Updates Nx target dependency behavior for serve and overrides start dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__", | ||
| "dependsOn": [] |
There was a problem hiding this comment.
dependsOn: [] on the start target overrides the workspace default start dependencies (see nx.json start target defaults) and will skip running build / gen-keys before starting PM2. Unless those steps are guaranteed to run elsewhere in your deployment/local workflow, this can result in starting stale artifacts or missing generated keys. Consider removing this override to inherit defaults, or explicitly listing the required prerequisites for payments-api:start.
| "command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__", | |
| "dependsOn": [] | |
| "command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__" |
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3321
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.