Skip to content

fix(payments-api): stripe webhooks not recording glean #20421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StaberindeZA wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −6
Open

fix(payments-api): stripe webhooks not recording glean #20421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/payments/api/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"continuous": true,
"executor": "@nx/js:node",
"defaultConfiguration": "development",
"dependsOn": ["build"],
"options": {
"buildTarget": "payments-api:build",
"runBuildTargetDependencies": false
Expand All @@ -70,7 +69,8 @@
}
},
"start": {
"command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__"
"command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__",
"dependsOn": []
Comment on lines +72 to +73
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependsOn: [] on the start target overrides the workspace default start dependencies (see nx.json start target defaults) and will skip running build / gen-keys before starting PM2. Unless those steps are guaranteed to run elsewhere in your deployment/local workflow, this can result in starting stale artifacts or missing generated keys. Consider removing this override to inherit defaults, or explicitly listing the required prerequisites for payments-api:start.

Suggested change
"command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__",
"dependsOn": []
"command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__"

Copilot uses AI. Check for mistakes.
},
"stop": {
"command": "pm2 stop apps/payments/api/pm2.config.js"
Expand Down
15 changes: 11 additions & 4 deletions apps/payments/api/src/app/app.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@ import { CurrencyManager } from '@fxa/payments/currency';
import { AccountDatabaseNestFactory } from '@fxa/shared/db/mysql/account';
import { AccountManager } from '@fxa/shared/account/account';
import { CartManager } from '@fxa/payments/cart';
import { CmsContentValidationManager, ProductConfigurationManager, StrapiClient } from '@fxa/shared/cms';
import {
MockPaymentsGleanFactory,
CmsContentValidationManager,
ProductConfigurationManager,
StrapiClient,
} from '@fxa/shared/cms';
import {
PaymentsGleanManager,
PaymentsGleanService,
} from '@fxa/payments/metrics';
Expand All @@ -60,7 +63,12 @@ import { NimbusClient, NimbusClientConfig } from '@fxa/shared/experiments';
}),
}),
],
controllers: [AppController, CmsWebhooksController, FxaWebhooksController, StripeWebhooksController],
controllers: [
AppController,
CmsWebhooksController,
FxaWebhooksController,
StripeWebhooksController,
],
providers: [
Logger,
AccountDatabaseNestFactory,
Expand Down Expand Up @@ -96,7 +104,6 @@ import { NimbusClient, NimbusClientConfig } from '@fxa/shared/experiments';
NimbusManagerConfig,
NimbusClient,
NimbusClientConfig,
MockPaymentsGleanFactory,
],
})
export class AppModule {}
Loading