JavaScript: Exclude parsed URL host/hostname checks from incomplete URL substring sanitization#27
Open
mrigankpawagi wants to merge 1 commit into
Open
JavaScript: Exclude parsed URL host/hostname checks from incomplete URL substring sanitization#27mrigankpawagi wants to merge 1 commit into
mrigankpawagi wants to merge 1 commit into
Conversation
…RL substring sanitization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
js/incomplete-url-substring-sanitizationquery by excluding substring checks performed on a parsed URL's.hostor.hostnameproperty from being flagged.Problem
MRVA on the top-100 JavaScript repositories revealed 98 alerts, several of which are false positives where developers correctly check a parsed URL's host property:
When
.endsWith()or.includes()is called onurl.hostorurl.hostname(rather than the raw URL string), the check is inherently safe because:host.endsWith("github.com")correctly matchesgithub.comand*.github.comChanges
Added a new whitelist case in
IncompleteUrlSubstringSanitization.qllthat excludes checks where the base string being tested comes from a.hostor.hostnameproperty read (viaDataFlow::PropRead).MRVA Validation
url.includes("cdn.jsdelivr.net")) are still correctly flaggedWhy this is correct
The
URLconstructor (orwindow.location) parses a URL and exposes its components separately:.host→"github.com"or"github.com:443".hostname→"github.com".pathname→"/path/to/resource"Once you have the isolated hostname, substring checks like
.endsWith("github.com")cannot be bypassed by crafting URLs with tricky paths likehttps://evil.com/github.com. The path component has already been separated out.