Skip to content

JavaScript: Exclude parsed URL host/hostname checks from incomplete URL substring sanitization #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrigankpawagi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JavaScript: Exclude parsed URL host/hostname checks from incomplete URL substring sanitization #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions javascript/ql/src/Security/CWE-020/IncompleteUrlSubstringSanitization.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,18 @@ query predicate problems(
// the trailing port or slash makes the prefix-check safe
check instanceof StringOps::StartsWith and
target.regexpMatch(".*(:[0-9]+|/)")
or
// Checks on a parsed URL's host or hostname property are safe,
// since the host is already isolated from path/query components.
exists(DataFlow::PropRead hostRead |
hostRead.getPropertyName() in ["host", "hostname"] and
(
check.(StringOps::EndsWith).getBaseString().getALocalSource() = hostRead
or
check.(StringOps::Includes).getBaseString().getALocalSource() = hostRead
or
check.(StringOps::StartsWith).getBaseString().getALocalSource() = hostRead
)
)
)
}
4 changes: 4 additions & 0 deletions javascript/ql/src/change-notes/2025-06-28-url-substring-host-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: majorAnalysis
---
* The `js/incomplete-url-substring-sanitization` query no longer flags substring checks performed on a parsed URL's `.host` or `.hostname` property (e.g., `new URL(x).host.endsWith("github.com")`), since the hostname is already isolated from path and query components, making such checks safe.
Loading