fix(preview): delete version metadata by preview ID - #63251
Open
joshtrichards wants to merge 2 commits into
Open
fix(preview): delete version metadata by preview ID#63251joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
come-nc and
icewind1991
and removed request for
a team
August 14, 2026 16:46
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Signed-off-by: Josh <josh.t.richards@gmail.com>
solracsf
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete version metadata using the specific
preview_versionsrow referenced by the preview.insert()creates onepreview_versionsrow whose ID is the preview ID, and stores that ID inpreviews.version_id. Thedelete()query should therefore useversion_idrather than(file_id, version), which can match multiple previews (i.e. different dimensions) for the same file version.Previously, deleting one preview could remove the
preview_versionsrows belonging to other previews of the same file version.Changes:
version_id.preview_versionsby itsid.version_idis-1TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)