Skip to content

fix(preview): delete version metadata by preview ID #63251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 2 commits into from
Aug 15, 2026
+9 −4
Merged

fix(preview): delete version metadata by preview ID #63251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75fd7f2
fix(preview): delete version metadata by preview ID
joshtrichards Aug 14, 2026
70938c2
fix(preview): declare Preview version ID getter
joshtrichards Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/private/Preview/Db/Preview.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
* @method string getEtag() Get the etag of the preview.
* @method void setEtag(string $etag)
* @method string|null getVersion() Get the version for files_versions_s3
* @method void setVersionId(string $versionId)
* @method string|null getVersionId() Get the ID of the version metadata row.
* @method void setVersionId(string $versionId) Set the ID of the version metadata row.
* @method bool|null getIs() Get the version for files_versions_s3
* @method bool isEncrypted() Get whether the preview is encrypted. At the moment every preview is unencrypted.
* @method void setEncrypted(bool $encrypted)
Expand Down
10 changes: 7 additions & 3 deletions lib/private/Preview/Db/PreviewMapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,15 @@ public function update(Entity $entity): Entity {
public function delete(Entity $entity): Entity {
/** @var Preview $preview */
$preview = $entity;
if ($preview->getVersion() !== null && $preview->getVersion() !== '') {

$versionId = $preview->getVersionId();
if ($versionId !== null && $versionId !== '' && $versionId !== '-1') {
$qb = $this->db->getQueryBuilder();
$qb->delete(self::VERSION_TABLE_NAME)
->where($qb->expr()->eq('file_id', $qb->createNamedParameter($preview->getFileId())))
->andWhere($qb->expr()->eq('version', $qb->createNamedParameter($preview->getVersion())))
->where($qb->expr()->eq(
'id',
$qb->createNamedParameter($versionId),
))
->executeStatement();
}

Expand Down
Loading