Auto-delete s3://nextstrain-ncov-private/*#73
Open
victorlin wants to merge 2 commits into
Open
Conversation
|
|
||
| filter { | ||
| prefix = "trial/" | ||
| prefix = "branch/" |
Member
There was a problem hiding this comment.
Are all files under the branch/ prefix gone and not to come back?
Member
Author
There was a problem hiding this comment.
They're gone now, but new files could be added if ncov-ingest is run with config/debug_sample_gisaid.yaml. Same with .github/workflows/fetch-and-ingest-gisaid-master.yml for trial/.
joverlee521
reviewed
Jun 16, 2026
Comment on lines
-84
to
-87
| noncurrent_version_expiration { | ||
| noncurrent_days = 15 | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
If inheriting from the root rules, does this mean branch/ and trial/ will always keep one noncurrent version even after the object is deleted by expiration?
Member
Author
Use consistent naming and remove the now-redundant abort_incomplete_multipart_upload config from prefix-specific rules.
victorlin
force-pushed
the
victorlin/update-lifecycle-rules
branch
from
8f21bf7 to
f1c350e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/nextstrain/private/issues/180
Plan: 0 to add, 1 to change, 0 to destroy.
Checklist