-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
test: adapt buffer test for v8 sandbox #61772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codebytere
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
codebytere:buffer-sandbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
reviewed
Feb 11, 2026
8173028 to
b1bbd4c
Compare
targos
approved these changes
Feb 11, 2026
addaleax
approved these changes
Feb 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61772 +/- ##
==========================================
+ Coverage 89.73% 89.75% +0.01%
==========================================
Files 675 675
Lines 204648 204648
Branches 39330 39330
==========================================
+ Hits 183651 183684 +33
+ Misses 13282 13250 -32
+ Partials 7715 7714 -1 🚀 New features to boost your workflow:
|
Collaborator
Renegade334
approved these changes
Feb 11, 2026
cjihrig
approved these changes
Feb 11, 2026
richardlau
approved these changes
Feb 11, 2026
lpinca
approved these changes
Feb 11, 2026
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #60405
This test will fail for V8 sandboxed builds, where the upper bound will be 2³⁵ - 1 instead of
Number.MAX_SAFE_INTEGER.