18 codeblock button changes position when copy and past smth#21
Merged
luca-chen198 merged 2 commits intoMay 14, 2026
Merged
Conversation
… keep their background AppKit doesn't fire textDidChange for setMarkedText mutations, so the inserted character keeps base typingAttributes. The previous override only restyled when the line started with `#`, which fixed heading inline-prediction but left code-block (and inline-code/LaTeX) lines without their background while dead keys like `, ^ were composing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
textViewDidChangeSelection fires before textDidChange when typing, so viewRect returned the pre-restyle layout and the overlay button briefly rendered at the old Y before settling. textDidChange already runs the update after restyle, so the selection-change pass can skip it when a pending edit is in flight (same guard the restyle path uses). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.