Skip to content

18 codeblock button changes position when copy and past smth #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luca-chen198 merged 2 commits into from
May 14, 2026
Merged

18 codeblock button changes position when copy and past smth #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
679b617
Restyle marked text outside heading lines so dead keys in code blocks…
luca-chen198 May 14, 2026
94bf769
Skip codeblock-button update during pending edit to avoid stale Y flash
luca-chen198 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/MarkdownEngine/TextView/Coordinator/NativeTextViewCoordinator+TextDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,10 @@ extension NativeTextViewCoordinator {
self.previousActiveTokenIndices = self.activeTokenIndices
self.previousCaretLocation = caretLoc

// Track code blocks for button overlay (reuse tokens)
updateCodeBlockSelection(textView: tv, tokens: tokens)
// Skip during a pending edit — viewRect is stale until textDidChange's restyle runs; otherwise the overlay flashes to the old Y before settling.
if !shouldSkipSelectionRestyle {
updateCodeBlockSelection(textView: tv, tokens: tokens)
}
}

public func textView(_ textView: NSTextView, shouldChangeTextIn affectedCharRange: NSRange, replacementString: String?) -> Bool {
Expand Down
4 changes: 1 addition & 3 deletions Sources/MarkdownEngine/TextView/NativeTextView/NativeTextView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ final class NativeTextView: NSTextView {
}
}

// AppKit doesn't fire textDidChange for setMarkedText mutations, so Apple's inline-prediction inserts the completion with base typingAttributes and heading lines flicker to body font; restyle the paragraph here to reapply heading font.
// AppKit skips textDidChange for setMarkedText, so markdown attrs (heading font, code-block bg) don't reach the marked range — restyle the affected paragraph to fix it.
override func setMarkedText(_ string: Any, selectedRange: NSRange, replacementRange: NSRange) {
super.setMarkedText(string, selectedRange: selectedRange, replacementRange: replacementRange)
guard hasMarkedText(),
Expand All @@ -67,8 +67,6 @@ final class NativeTextView: NSTextView {
guard marked.location != NSNotFound, marked.length > 0 else { return }
let nsText = self.string as NSString
let paragraph = nsText.paragraphRange(for: marked)
let line = nsText.substring(with: nsText.lineRange(for: NSRange(location: paragraph.location, length: 0)))
guard line.hasPrefix("#") else { return }
coord.restyleParagraphs([paragraph], in: self)
}

Expand Down
Loading