Removed custom_output_names from the separate file call.#260
Removed custom_output_names from the separate file call.#260Kulin-Soni wants to merge 2 commits intonomadkaraoke:mainfrom
Conversation
Removed custom_output_names from _separate_file call inside the _process_with_chunking method. This prevents the processed chunks from getting the same custom name, and rather have the `chunk_N` naming.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughRemoved the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use your project's `ruff` configuration to improve the quality of Python code reviews.Add a Ruff configuration file to your project to customize how CodeRabbit runs |
|
Can you make sure all the tests pass too please? 🙏 |
|
sure, will do soon |
|
@beveradb Tests done! |
Removed custom_output_names from _separate_file call inside the _process_with_chunking method. This prevents the processed chunks from getting the same custom name, and have the
chunk_Nnaming.This prevents overwriting previous chunks.
This is a fix to #259
Summary by CodeRabbit