Skip to content

Removed custom_output_names from the separate file call. #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kulin-Soni wants to merge 2 commits into from
Closed

Removed custom_output_names from the separate file call. #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b0895f
Removed custom_output_names from the separate file call.
Kulin-Soni Mar 8, 2026
396a7dc
Fixed parameter chunk_names to be optional in track_state
Kulin-Soni Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion audio_separator/separator/separator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@ def _process_with_chunking(self, audio_file_path, custom_output_names=None):
self.model_instance.output_dir = temp_dir

try:
output_files = self._separate_file(chunk_path, custom_output_names)
output_files = self._separate_file(chunk_path)

# Dynamically group chunks by stem name
for stem_path in output_files:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_separator_chunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def test_state_restoration_after_chunking(self, mock_chunker_class):

# Track state changes during _separate_file call
state_during_processing = {}
def track_state(chunk_path, custom_names):
def track_state(chunk_path, custom_names=None):
state_during_processing['chunk_duration'] = separator.chunk_duration
state_during_processing['output_dir'] = separator.output_dir
state_during_processing['model_output_dir'] = separator.model_instance.output_dir
Expand Down
Loading