Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test-only reproduction for the Windows process-tree shutdown race from #150. No production shutdown code changes.
The regression launches a real Windows leader that owns an ignored-stdio descendant and exits on stdin EOF. It models
taskkillbeginning too late to retain the leader as the tree root, then requiressession.close()to have terminated the descendant.Expected CI result
The new test is Windows-only. Linux skips it;
windows-latestshould fail against currentmainuntil cleanup is verified before stdin EOF can release the leader.Verification
npx vitest run tests/omp-rpc-process.test.ts— 9 passed, 2 Windows-only skipped on Linuxnpm run typechecknpm run checknpm test— 823 passed, 5 skipped on LinuxThe diff contains only
paseo-omp/tests/omp-rpc-process.test.ts.