Repository navigation
chore(docs): move to nuxt 5 and nitro 3 - #369
Merged
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes across the Nuxt 5 and Nitro 3 docs migration, including the Cloudflare runtime boundary and generated asset routing.
- Framework migration: Pins the docs app to the Nuxt 5 nightly and Nitro 3 RC used by ViteHub's consumer tests, and aligns all ViteHub preview packages to one upstream commit.
- Cloudflare runtime access: Moves Assets, secrets, and
waitUntilaccess to Nitro 3'sevent.req.runtime.cloudflarecontract while preserving the incoming request for asset dispatch. - Markdown negotiation: Serves negotiated Markdown from ViteHub's generated
/raw/*.mdpaths and updates the focused regression assertions. - Deployment configuration: Keeps trailing-slash page URLs in Wrangler, adds the PKCE
workerdexport backport, and prevents formatter-produced JSONC trailing commas. - Patch cleanup: Removes the superseded ViteHub docs and web-container backports and their temporary package metadata.
gpt-5.6-sol ｜ 𝕏
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
Contributor
Latest result Pull request merged. Final answersSession Pull request merged. Ready; no actionable findings or repair needed. After docs preparation, `pnpm --dir docs exec vp test run ../test/site.test.ts --dir ../test` passed all 12 tests. Focused `vp lint`, `vp fmt --check`, and `git diff --check` passed. Validation used installed dependencies with automatic reinstall disabled. All six supplied checks passed. Pullfrog found no issues; Codex review was unavailable due usage limits. Checkout remains clean. |
Closed
vite-hub Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
…s, and style headings (#370) * fix(docs): ship the fonts again and style the page headings Nitro 3 never calls rollup:before, where @nuxt/fonts 0.14 fills its font files, so every /_fonts file deployed empty since #369. Nuxt UI's dependency on it now resolves to 1.2, which downloads the fonts when Vite closes the bundle. comark-links draws the docs' headings, so Nuxt UI's ProseH2 never styles them and they rendered as 16px body text. The docs app now gives them ProseH2's sizes and spacing. * fix(docs): list each package's category in its sidebar, and draw Annotate's rail icon Every package page is a one-page section, so @vite-hub/docs showed a sidebar with a single link to the current page. A pnpm patch backports vite-hub/vitehub#3559, which lists the section's category instead. Lucide has no scribble-loop, so Annotate's rail item drew no icon. content.ts maps it to pen-tool, as the landing's package grid does.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs run Nuxt 4 and Nitro 2, so they don't exercise the stack we want ViteHub to support first.
This moves them to
nuxt-nightly@5.0.0-2611031025-9496b7eandnitro@3.0.261102-rc, with the published packages from vite-hub/vitehub#3544 at298ec15. It removes the two ViteHub backport patches, reads Cloudflare bindings from Nitro 3's request runtime, and serves Markdown from ViteHub's/raw/paths. Wrangler keeps trailing-slash page URLs. PKCE needs a small export-condition backport for Workers, and Nitro's JSONC parser needs a formatter override to keep trailing commas out of the Wrangler config.Verified locally:
$DurableObject, and the Worker dry run passes.--maxWorkers=2: 2,748 passed, 1 expected failure and 1 skipped. The first unrestricted run hit two timeouts. The Markdown regression test fails against main's source and passes here.pnpm install --frozen-lockfile --ignore-scriptspasses.Nuxt still applies its Nitro 2 compatibility layer to some third-party modules. Authenticated OAuth, comments and MCP flows weren't exercised locally because the local Worker has no auth secrets. Nothing has been deployed.