Skip to content

Add PHP 8 support#14

Closed
malberts wants to merge 1 commit intoonoi:masterfrom
malberts:2022
Closed

Add PHP 8 support#14
malberts wants to merge 1 commit intoonoi:masterfrom
malberts:2022

Conversation

@malberts
Copy link
Copy Markdown

@malberts malberts commented Dec 9, 2022

This primarily addresses SemanticMediaWiki/SemanticMediaWiki#5346

@malberts
Copy link
Copy Markdown
Author

malberts commented Dec 9, 2022

I realised later there was already a PR doing some of these updates: #12
However, in my case I dropped PHP 7 (the other PR supports 7.3+). Since PHP 7.4 is now completely EOL, I think this is a good time to make a breaking major release (v2).

@JeroenDeDauw
Copy link
Copy Markdown
Contributor

Uh oh. Dunno if anyone has write or admin on this repo. @kghbln are you able to merge this PR?

@kghbln
Copy link
Copy Markdown
Contributor

kghbln commented Dec 9, 2022

No, there is nobody left in onoi who can merge. Last time this happened for this org the respective lib was moved to SMW core.

@JeroenDeDauw
Copy link
Copy Markdown
Contributor

That won't work for this repo since there are users besides SMW itself. So we need to create a copy of the repo somewhere. Perhaps on SMW org, or the ProfessionalWiki one?

@kghbln
Copy link
Copy Markdown
Contributor

kghbln commented Dec 9, 2022

Perhaps on SMW org, or the ProfessionalWiki one?

Yeah. This one looked a bit more like a general lib to me. I think that SMW is the more suitable org here.

@JeroenDeDauw
Copy link
Copy Markdown
Contributor

Repo ready here: https://github.com/SemanticMediaWiki/http-request

@malberts you have admin on it

So far I just pulled and pushed master

We will also need new package name, and use the replace section like at https://github.com/JeroenDeDauw/PsrLogTestDoubles/blob/master/composer.json#L3-L5

@malberts
Copy link
Copy Markdown
Author

malberts commented Dec 9, 2022

Replaced by SemanticMediaWiki/http-request#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants