Fix global tox test matrix failures and linters - #367
Open
royrhea wants to merge 1 commit into
Open
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-08-09 19:01 UTC Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):
Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize repo-wide CI/linting by reducing noise and failures from generated/virtualenv directories and aligning pytest-asyncio behavior with expected fixture scoping.
Changes:
- Update the
shellchecktox env to skip.tox,.venv, andtest_envdirectories and avoid runningshellcheckwhen no scripts are found. - Exclude
test_envfrom the license-header checker and codespell scans. - Set
pytest-asyncio’s default fixture loop scope tofunctionviapytest.ini.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tox.ini |
Adjusts shellcheck invocation and directory exclusions for repo-wide lint stability. |
scripts/check_license_header.py |
Skips test_env to avoid false failures when scanning for SPDX headers. |
pytest.ini |
Sets asyncio_default_fixture_loop_scope to reduce asyncio/fixture-related test failures. |
.codespellrc |
Excludes test_env from spelling checks to avoid scanning generated environments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| commands = | ||
| sh -c "find {toxinidir} -name \*.sh | xargs shellcheck --severity=warning" | ||
| sh -c "find {toxinidir} -type f -name \*.sh -not -path '*/.tox/*' -not -path '*/.venv/*' -not -path '*/test_env/*' | xargs --no-run-if-empty shellcheck --severity=warning" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue, if any, is fixed.
Include the motivation and context for the change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. List any relevant details for your test
configuration.
Checklist
See CONTRIBUTING.md
for the style guide, changelog guidance, and more.