Skip to content

Fix global tox test matrix failures and linters #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
royrhea wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Fix global tox test matrix failures and linters #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codespellrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
[codespell]
check-hidden = true
# skipping auto generated folders
skip = ./.git,./.tox,./.venv,./.mypy_cache,./docs/_build,./target,*/LICENSE,./venv,*/cassettes
skip = ./.git,./.tox,./.venv,./test_env,./.mypy_cache,./docs/_build,./target,*/LICENSE,./venv,*/cassettes
ignore-words-list = ot
1 change: 1 addition & 0 deletions pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
addopts = -rfE -v
log_cli = true
log_cli_level = warning
asyncio_default_fixture_loop_scope = function

@lmolkova lmolkova Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't reach the packages that define their own [tool.pytest.ini_options]. pytest stops its config lookup at the package pyproject.toml and never reads root pytest.ini. Affected: anthropic, agno, crewai, smolagents, llama-index, claude-agent-sdk. Those envs will keep emitting the warning.

Simplest fix: drop the [tool.pytest.ini_options] blocks from those six pyproject.tomls so root config applies everywhere. Otherwise the setting has to be duplicated into each.

1 change: 1 addition & 0 deletions scripts/check_license_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"target",
".tox",
".venv",
"test_env",

@lmolkova lmolkova Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_env looks like a local venv name rather than a repo convention. .gitignore uses venv*/ and .venv*/, so this is better handled there, or by renaming the venv to venv-test, instead of adding it to three shared configs.

SKIP_DIRS matches path components anywhere, so this also means any real directory named test_env silently skips the license-header gate.

Suggested change
"test_env",

Same for the ./test_env entry in .codespellrc.

"__pycache__",
"node_modules",
)
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ commands_pre =
sh -c "sudo apt update -y && sudo apt install --assume-yes shellcheck"

commands =
sh -c "find {toxinidir} -name \*.sh | xargs shellcheck --severity=warning"
sh -c "find {toxinidir} -type f -name \*.sh -not -path '*/.tox/*' -not -path '*/.venv/*' -not -path '*/test_env/*' | xargs --no-run-if-empty shellcheck --severity=warning"

@lmolkova lmolkova Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exclusion list misses venv/, which .gitignore explicitly allows, so a conventionally named local venv still gets scanned. Suggest driving the exclusions off the .gitignore patterns and dropping test_env:

Suggested change
sh -c "find {toxinidir} -type f -name \*.sh -not -path '*/.tox/*' -not -path '*/.venv/*' -not -path '*/test_env/*' | xargs --no-run-if-empty shellcheck --severity=warning"
sh -c "find {toxinidir} -type f -name \*.sh -not -path '*/.tox/*' -not -path '*/.venv*/*' -not -path '*/venv*/*' | xargs shellcheck --severity=warning"

--no-run-if-empty is GNU-only and never triggers here since find always matches the scripts in scripts/, so leaving it off keeps the command working on macOS too.


[testenv:{precommit,ruff}]
basepython: python3
Expand Down
Loading