Skip to content

fix(cli): show scan scope before verified review progress - #464

Draft
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/truthful-scan-scope-progress
Draft

fix(cli): show scan scope before verified review progress#464
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/truthful-scan-scope-progress

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Show the number of files in scope until verified review progress becomes available. This addresses the inventory-before-progress portion of #70.

Changes

  • Render N in scope when inventory is known but no reviewed files have been verified.
  • Switch to completed / total reviewed once a positive completed count is available.
  • Extend the existing dashboard regression to cover both states and reject misleading 0 / N reviewed output.
  • Merge current main without changing publication or Deep scan presentation.

Testing

  • bun test --timeout 30000 tests-ts/scan-dashboard.test.ts tests-ts/worker-progress.test.ts — 38 passed, 196 assertions.
  • bun test --timeout 30000 tests-ts/cli.test.ts --test-name-pattern dashboard — 4 passed, 43 assertions.
  • bun test --timeout 30000 ./tests-ts — 1,293 passed, 11 skipped, zero failed; 9,148 assertions across 63 files.
  • bun test --timeout 30000 --randomize --seed 12345 ./tests-ts — 1,293 passed, 11 skipped, zero failed; 9,148 assertions across 63 files.
  • pnpm run types — passed.
  • pnpm exec prettier --check src/scan-dashboard.ts tests-ts/scan-dashboard.test.ts — passed.
  • pnpm run format — passed.
  • git diff 5d1afcd312933121e36dc892dcb12e8d2e3e1de3...HEAD --check — passed.

Risk and rollout

Presentation-only dashboard change. No new telemetry, estimated percentages, scan-state tracking, or phase/activity behavior. Broader progress concerns in #70 remain out of scope. The standard and fixed-seed randomized SDK suites pass locally. Current-head CI and repository-supported review are still required before merge.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

Newly authored material was reviewed for public disclosure. Existing automated review comments contain access-restricted report references; maintainer cleanup remains outstanding.

@github-actions github-actions Bot added the bug Something isn't working label Aug 15, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 1f2fd79f7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 1f2fd79f7a

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, e7d078222b581381915fa64a29c8ba6630278416.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: e7d078222b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: e7d078222b

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant