fix(cli): show scan scope before verified review progress - #464
fix(cli): show scan scope before verified review progress#464mldangelo-oai wants to merge 2 commits into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Show the number of files in scope until verified review progress becomes available. This addresses the inventory-before-progress portion of #70.
Changes
N in scopewhen inventory is known but no reviewed files have been verified.completed / total reviewedonce a positive completed count is available.0 / N reviewedoutput.Testing
bun test --timeout 30000 tests-ts/scan-dashboard.test.ts tests-ts/worker-progress.test.ts— 38 passed, 196 assertions.bun test --timeout 30000 tests-ts/cli.test.ts --test-name-pattern dashboard— 4 passed, 43 assertions.bun test --timeout 30000 ./tests-ts— 1,293 passed, 11 skipped, zero failed; 9,148 assertions across 63 files.bun test --timeout 30000 --randomize --seed 12345 ./tests-ts— 1,293 passed, 11 skipped, zero failed; 9,148 assertions across 63 files.pnpm run types— passed.pnpm exec prettier --check src/scan-dashboard.ts tests-ts/scan-dashboard.test.ts— passed.pnpm run format— passed.git diff 5d1afcd312933121e36dc892dcb12e8d2e3e1de3...HEAD --check— passed.Risk and rollout
Presentation-only dashboard change. No new telemetry, estimated percentages, scan-state tracking, or phase/activity behavior. Broader progress concerns in #70 remain out of scope. The standard and fixed-seed randomized SDK suites pass locally. Current-head CI and repository-supported review are still required before merge.
Public disclosure review
Newly authored material was reviewed for public disclosure. Existing automated review comments contain access-restricted report references; maintainer cleanup remains outstanding.