Skip to content

fix(cli): show scan scope before verified review progress #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mldangelo-oai wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −2
Draft

fix(cli): show scan scope before verified review progress #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f2fd79
fix(cli): show scan scope before verified review progress
mldangelo-oai Aug 15, 2026
e7d0782
Merge main into truthful scan scope progress
mldangelo-oai Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/typescript/src/scan-dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,9 @@ export class ScanDashboard {
const files =
this.#files === null
? "waiting for inventory"
: `${formatCount(this.#files.filesCompleted)} / ${formatCount(this.#files.filesTotal)} reviewed`;
: this.#files.filesCompleted > 0
? `${formatCount(this.#files.filesCompleted)} / ${formatCount(this.#files.filesTotal)} reviewed`
: `${formatCount(this.#files.filesTotal)} in scope`;
const tokens =
this.#cost === null
? "waiting for usage"
Expand Down
9 changes: 8 additions & 1 deletion sdk/typescript/tests-ts/scan-dashboard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@ describe("live scan dashboard", () => {
output_tokens: 236,
}).cost!,
);
dashboard.setFiles({
phase: "discovery",
filesCompleted: 3,
filesTotal: 1_258,
});
dashboard.stop();

const text = stripVTControlCharacters(stderr.text());
Expand All @@ -290,7 +295,9 @@ describe("live scan dashboard", () => {
expect(text).toContain(" routes/login.ts");
expect(text).not.toContain("[09:41:19] routes/login.ts");
expect(text).toContain("routes/login.ts");
expect(text).toContain("0 / 1,258 reviewed");
expect(text).toContain("1,258 in scope");
expect(text).not.toContain("0 / 1,258 reviewed");
expect(text).toContain("3 / 1,258 reviewed");
expect(text).not.toContain("opened");
expect(text).not.toContain("3 / 6 active");
expect(text).toContain("17,985 in · 10,496 cached · 236 out");
Expand Down
Loading