Skip to content

perf(skills): resolve plugin namespaces per root#31348

Open
anp-oai wants to merge 2 commits into
codex/skill-namespace-loader-testsfrom
codex/skill-namespace-root-probes
Open

perf(skills): resolve plugin namespaces per root#31348
anp-oai wants to merge 2 commits into
codex/skill-namespace-loader-testsfrom
codex/skill-namespace-root-probes

Conversation

@anp-oai

@anp-oai anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Why

Loading skills from a remote executor can add a lot to thread start time when there are many skills. Previous changes added some concurrency for the file reads themselves, but we're still bottlenecked on the initial root path discovery.

Using the benchmark from #31295, this change reduces the measured mean of loading 66 skills about 71%. Behavioral coverage lands separately in #31369.

What

  • resolve the scanned root's inherited namespace once
  • resolve discovered nested plugin roots once, retaining nearest-valid-ancestor behavior
  • pass an explicit resolved Plain / Plugin namespace into skill parsing instead of probing per skill
  • preserve explicitly provided plugin namespaces as the highest-priority source
  • reuse the same resolver for environment skills, deleting its duplicate root-probe and ancestor-selection path

Validation

  • just test -p codex-core-skills namespace: 12 passed on both the parent and optimized branches

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e78052927

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-skills/src/loader/namespace.rs
anp-oai added a commit that referenced this pull request Jul 7, 2026
@anp-oai

anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

anp-oai added a commit that referenced this pull request Jul 7, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 3d5c853552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
@anp-oai anp-oai force-pushed the codex/skill-namespace-root-probes branch from d4dd9c1 to 0e5ca67 Compare July 7, 2026 05:35
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
anp-oai added a commit that referenced this pull request Jul 7, 2026
@anp-oai anp-oai force-pushed the codex/skill-namespace-root-probes branch from 2febcf8 to f0118ce Compare July 7, 2026 06:21
@anp-oai anp-oai changed the base branch from main to codex/skill-namespace-loader-tests July 7, 2026 06:21
@anp-oai

anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0118ce83e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-skills/src/loader/namespace.rs Outdated
Comment thread codex-rs/core-skills/src/loader.rs
@anp-oai anp-oai force-pushed the codex/skill-namespace-root-probes branch from f0118ce to d59b7b3 Compare July 7, 2026 06:43
@anp-oai

anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: d59b7b3901

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant