app-server: reserve running resumes before idle unload#31392
Open
winston-openai wants to merge 1 commit into
Open
app-server: reserve running resumes before idle unload#31392winston-openai wants to merge 1 commit into
winston-openai wants to merge 1 commit into
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reserve a running
thread/resumeagainst idle unload before its listener command is enqueued. The reservation is keyed by an opaque per-request token, remains active while the primary response is delivered, and is committed to a subscription or canceled by a tracked supervisor after the listener reports the exact outcome.Idle unload now takes the global thread-list permit and rechecks both committed connections and pending resume reservations before claiming the thread. Disconnect and unsubscribe cleanup retain bookkeeping until the last real subscription or reservation is gone.
This closes the gap where an idle listener could begin unloading a loaded thread between resume admission and listener subscription. Exact tokens also prevent a delayed completion from an older resume from consuming or subscribing a newer request on the same connection.
Stacked on #31388.
Validation