app-server: track idle thread teardown#31395
Open
winston-openai wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the idle-unload marker set and detached teardown task with a tracked singleflight coordinator. A claim is registered together with its tracked supervisor, owns an exact completion channel, rolls back when a provisional claim is dropped, and remains visible until that owner finishes or unwinds.
The idle listener now hands shutdown to the tracked owner, removes and waits for the exact listener generation, and lets the coordinator release the claim. Graceful and in-process shutdown clear listeners, drain owned teardowns, and only then shut down remaining threads. Forced restart retains its existing non-blocking behavior.
This makes idle teardown survive cancellation of its first waiter without allowing an older owner to clear a replacement claim. Manual cleanup no longer mutates coordinator ownership; its remaining paths are migrated in the next stacked layer.
Stacked on #31392.
Validation