fix(child-sessions): preserve configured shell in headless tools - #423
Merged
Conversation
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
github-actions
Bot
added
the
area:ui
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
Signed-off-by: seekskyworld <djh1813553759@gmail.com>
github-actions
Bot
added
the
documentation
# Conflicts: # docs/research/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The display extension re-registers Bash during headless startup without Pi's configured shell settings. Derived sessions can therefore select the wrong shell, especially on Windows. Closes #419.
Value
Direct and Workflow children, print and RPC sessions retain Pi's native tool definitions and configured shell behavior.
Approach
Only replace tools and change display state in TUI mode. A real child-session regression configures a nonexistent shell and proves headless binding preserves Pi's explicit configuration error. Existing display tests exercise TUI mode.
Validation
Integrated main
0bd00417c43e1f2d89630ceffe705592ea186f79.bun run checkand standardbun run testpassed: 1456 Node tests, one platform skip, Vitest 30/30. Two independent reviews found no actionable regression. Final-head CI passed on2d5eaf9for Node 22, Node 24 and Windows. The initial Windows run failed in the preexisting concurrent worktree creation test without a Git error receipt; the unchanged-head failed-job rerun passed. No test or runtime workaround was introduced.Impact
No tool schema, configuration or persisted-data change. Headless sessions retain native tools; interactive rendering remains unchanged. The preexisting TUI shell-settings issue is not fixed by this headless-only PR.