fix(subagents): support Pi tools, target workspaces, and Cursor execution - #426
Merged
Conversation
This was referenced Sep 6, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow children could fail before useful work for several independent reasons: Cursor rejected every tool invocation, investigator roles excluded shell/network tools, Workflow had no explicit child cwd, and a local 45-second output timer cut off otherwise live Pi requests. This change makes ordinary and Workflow children usable through Pi's own tools and lifecycle.
working_dir, including target trust, replay/operator identity and worktree cleanup. Inherited roles execute for real on resume; bounded custom read-only replay stays restricted.Existing custom role files are preserved: an old explicit
explorer.mdallowlist still excludes shell/network until deliberately edited. This is an intended widening of built-in role capabilities in normal mode, not a filesystem sandbox. The current installed runtime is not changed by this PR.Validation:
bun run checkpassed. The full repository-discovered test set passed with Node file concurrency 2: 1435 passed, 1 platform skip; Vitest 30/30. The defaultbun run testrun hit the pre-existing Setup subprocess 8-second startup deadline under local host load; its failure is retained rather than changing that unrelated test. Two independent reviews found no actionable defects. Live Cursor Grok accepted the Pi tool/result round trip; a real Workflow child read outside cwd and fetched HTTPS through Bash; eight concurrent production-runner children passed 8/8 in about 12 seconds. These small acceptance runs do not establish long-audit quality or account rate ceilings.Investigation and evidence boundaries: research record. Dashboard lag was fixed separately in #422. The independent Windows/headless shell configuration repair remains in #423.
Fixes #424
Final CI on
c3809e1f5c39d736054694724dce69a1099fe49d: Node 22.19.0, Node 24, and Windows all passed, including the standard repository commands and package smoke checks. Fixed review base:a7455cd378ef7befa9c7cf099c1fa1e4ee5dc3e3. CI receipt.