Netobserv 5.0 wait timeout#80504
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oliver-smakal The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughAcross four CI operator YAML files (releases 4.19, 4.20 amd64, 4.20 multi, and 5.0 amd64), Network Observability job definitions are updated to add a ChangesNetObserv CI Job Wait Step and Timeout
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml`:
- Around line 4397-4400: The `ref: wait` step in the test chain has been added
unconditionally to configurations that run as periodic cron jobs (where
`PR_ONLY` is not set), which will cause each execution to pause for 4 hours
before running the `openshift-e2e-test-netobserv-qe` chain. Either gate the
`ref: wait` step with `PR_ONLY: "true"` to ensure it only runs on pull requests,
or remove it entirely before merging if this is debug-only code. This applies at
multiple locations in the file where similar patterns exist with the wait
reference followed by the NetObserv chain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 262e2209-c483-4b38-be08-c95affa7e492
📒 Files selected for processing (4)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
| TIMEOUT: 4 hours | ||
| test: | ||
| - ref: wait | ||
| - chain: openshift-e2e-test-netobserv-qe |
There was a problem hiding this comment.
ref: wait introduces an unconditional 4-hour delay on periodic runs
Because these are cron jobs and PR_ONLY is not set, the added ref: wait will pause each execution for up to 4 hours before the NetObserv chain. If this is debug-only, gate it with PR_ONLY: "true" (or remove before merge) to avoid long-running periodic backlog.
Also applies to: 4428-4432, 4460-4464, 4485-4488
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml`
around lines 4397 - 4400, The `ref: wait` step in the test chain has been added
unconditionally to configurations that run as periodic cron jobs (where
`PR_ONLY` is not set), which will cause each execution to pause for 4 hours
before running the `openshift-e2e-test-netobserv-qe` chain. Either gate the
`ref: wait` step with `PR_ONLY: "true"` to ensure it only runs on pull requests,
or remove it entirely before merging if this is debug-only code. This applies at
multiple locations in the file where similar patterns exist with the wait
reference followed by the NetObserv chain.
|
/pj-rehearse pull-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6-netobserv |
|
@oliver-smakal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-metal-ds-ipi-ovn-ipv4-f28-virt-netobserv |
|
@oliver-smakal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-vsphere-ipi-amd-f28-ipsec-netobserv |
|
@oliver-smakal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-vsphere-ipi-amd-f29-techpreview-nwevents-netobserv |
|
@oliver-smakal: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@oliver-smakal: job(s): pull-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-vsphere-ipi-amd-f29-techpreview-nwevents-netobserv either don't exist or were not found to be affected, and cannot be rehearsed |
|
@oliver-smakal: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Not intended to merge, just for ocp 5.0 and netobserv testing
Summary by CodeRabbit
This PR adjusts the OpenShift CI test infrastructure for Network Observability (NetObserv) testing across multiple release versions. The changes are focused on test job configuration files that define how Prow executes CI tests for the openshift-tests-private repository.
What's changing:
The PR modifies Prow job definitions in the CI operator configuration to add timeout and wait step enhancements to NetObserv-related test jobs:
TIMEOUTvalues (4 hours for most jobs, 6 hours for ARM-based jobs) to prevent test hangs- ref: waitstep is prepended to the test phase of affected jobs, inserting a waiting period before the actual test chains executeAffected jobs and versions:
Files modified:
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yamlNote: This PR is explicitly marked as test-only and not intended for merging. The changes are debugging/validation adjustments to the CI testing infrastructure for NetObserv validation across OCP 5.0 and related releases.