Skip to content

Netobserv 5.0 wait timeout #80504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliver-smakal wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Netobserv 5.0 wait timeout #80504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d380a4
adjust bm jobs to be tested
Jun 1, 2026
66a94c8
debug arm
Jun 5, 2026
a72f3bb
revert unrelated changes
Jun 5, 2026
55c37a7
adjust wait time for debug
Jun 5, 2026
9ea2d30
add wait steps to netobserv bm testruns for testing
Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...penshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3801,7 +3801,9 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "77894"
TEST_TIMEOUT: "55"
TIMEOUT: 4 hours
test:
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-vsphere-ipi
- as: metal-ds-ipi-ovn-ipv4-f28-virt-netobserv
Expand All @@ -3828,10 +3830,12 @@ tests:
NETWORK_TYPE=OVNKubernetes
TEST_FILTERS: Network_Observability
TEST_IMPORTANCE: .*
TIMEOUT: + 4 hours
TEST_SCENARIOS: with VMs
TEST_TIMEOUT: "55"
test:
- chain: openshift-e2e-test-netobserv-prepare-bm-cluster
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-baremetalds-ipi-ovn
- as: metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6-netobserv
Expand Down Expand Up @@ -3860,8 +3864,10 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "53844"
TEST_TIMEOUT: "55"
TIMEOUT: 4 hours
test:
- chain: openshift-e2e-test-netobserv-prepare-bm-cluster
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-baremetalds-ipi-ovn
- as: vsphere-ipi-amd-f28-ipsec-netobserv
Expand All @@ -3883,7 +3889,9 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "82637"
TEST_TIMEOUT: "55"
TIMEOUT: 4 hours
test:
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-vsphere-ipi-ovn-ipsec
- as: vsphere-ipi-longduration-mco-fips-proxy-g1-f14
Expand Down
8 changes: 8 additions & 0 deletions ...penshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4697,7 +4697,9 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "77894"
TEST_TIMEOUT: "55"
TIMEOUT: + 4 hours
test:
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-vsphere-ipi
- as: metal-ds-ipi-ovn-ipv4-f28-virt-netobserv
Expand Down Expand Up @@ -4726,8 +4728,10 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: with VMs
TEST_TIMEOUT: "55"
TIMEOUT: + 4 hours
test:
- chain: openshift-e2e-test-netobserv-prepare-bm-cluster
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-baremetalds-ipi-ovn
- as: metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6-netobserv
Expand Down Expand Up @@ -4756,8 +4760,10 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "53844"
TEST_TIMEOUT: "55"
TIMEOUT: + 4 hours
test:
- chain: openshift-e2e-test-netobserv-prepare-bm-cluster
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-baremetalds-ipi-ovn
- as: vsphere-ipi-amd-f28-ipsec-netobserv
Expand All @@ -4779,7 +4785,9 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "82637"
TEST_TIMEOUT: "55"
TIMEOUT: + 4 hours
test:
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-vsphere-ipi-ovn-ipsec
- as: vsphere-ipi-longduration-mco-fips-proxy-g1-f14
Expand Down
2 changes: 2 additions & 0 deletions ...penshift-tests-private/openshift-openshift-tests-private-release-4.20__multi-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ tests:
BASE_DOMAIN: qe.devcluster.openshift.com
COMPUTE_NODE_TYPE: m6gd.2xlarge
OCP_ARCH: arm64
TIMEOUT: 6 hours
test:
- ref: wait
- chain: openshift-e2e-test-netobserv-qe-pf5
workflow: cucushift-installer-rehearse-aws-ipi
- as: aws-ipi-arm-mixarch-f14-day2-64k-pagesize
Expand Down
8 changes: 8 additions & 0 deletions ...openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4394,7 +4394,9 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "77894"
TEST_TIMEOUT: "55"
TIMEOUT: 4 hours
test:
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
Comment on lines +4397 to 4400

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

ref: wait introduces an unconditional 4-hour delay on periodic runs

Because these are cron jobs and PR_ONLY is not set, the added ref: wait will pause each execution for up to 4 hours before the NetObserv chain. If this is debug-only, gate it with PR_ONLY: "true" (or remove before merge) to avoid long-running periodic backlog.

Also applies to: 4428-4432, 4460-4464, 4485-4488

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml`
around lines 4397 - 4400, The `ref: wait` step in the test chain has been added
unconditionally to configurations that run as periodic cron jobs (where
`PR_ONLY` is not set), which will cause each execution to pause for 4 hours
before running the `openshift-e2e-test-netobserv-qe` chain. Either gate the
`ref: wait` step with `PR_ONLY: "true"` to ensure it only runs on pull requests,
or remove it entirely before merging if this is debug-only code. This applies at
multiple locations in the file where similar patterns exist with the wait
reference followed by the NetObserv chain.

workflow: cucushift-installer-rehearse-vsphere-ipi
- as: metal-ds-ipi-ovn-ipv4-f28-virt-netobserv
Expand Down Expand Up @@ -4423,8 +4425,10 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: with VMs
TEST_TIMEOUT: "55"
TIMEOUT: 4 hours
test:
- chain: openshift-e2e-test-netobserv-prepare-bm-cluster
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-baremetalds-ipi-ovn
- as: metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6-netobserv
Expand Down Expand Up @@ -4453,8 +4457,10 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "53844"
TEST_TIMEOUT: "55"
TIMEOUT: 4 hours
test:
- chain: openshift-e2e-test-netobserv-prepare-bm-cluster
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-baremetalds-ipi-ovn
- as: vsphere-ipi-amd-f28-ipsec-netobserv
Expand All @@ -4476,7 +4482,9 @@ tests:
TEST_IMPORTANCE: .*
TEST_SCENARIOS: "82637"
TEST_TIMEOUT: "55"
TIMEOUT: 4 hours
test:
- ref: wait
- chain: openshift-e2e-test-netobserv-qe
workflow: cucushift-installer-rehearse-vsphere-ipi-ovn-ipsec
- as: vsphere-ipi-longduration-mco-fips-proxy-p1-f14
Expand Down