Open
Conversation
Member
Author
|
Integration test is working with the latest release of ros2 iron, but the docker images are not updated yet. |
Member
|
Could you merge the latest main into the base branch also rebase/update this branch? |
added 11 commits
November 27, 2024 12:43
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
33ec5cf to
7e83337
Compare
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
abdd73f to
b85cc40
Compare
Member
|
I'm wondering, especially now that we bumped main to 24.04 and all the compiler versions are fairly recent, would it make sense to increase our C++ standard to C++23 and use std::expected rather than manually implementing our own |
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Member
Author
I'm down for that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preview of the work in removing exceptions.
Inspired from rust,
Result<T>is the alternative to exceptions. Internally it usesstd::variantto store either the result or astd::exception.[[nodiscard]]should almost always be used when returningResult<T>. We don't have custom lint rules so it will have to be checked manually.Result<void>is a special case that usingstd::optionalinstead.Result<T&>does not work becausestd::variantcannot contain references.Result<T>for all reference types and store a pointer internally instead.